Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports/esp32: Add missing newline-at-EOF for sdkconfig.240mhz #5237

Closed
wants to merge 1 commit into from

Conversation

jimmo
Copy link
Member

@jimmo jimmo commented Oct 21, 2019

Follow up to #5203

When these files get concatenated, the newline-at-EOF is necessary so that the start of the next file doesn't join with the end of the previous.

warning: the value '240# MicroPython on ESP32, ESP IDF configuration with SPIRAM support' is invalid for ESP32_DEFAULT_CPU_FREQ_MHZ, which has type int

@dpgeorge
Copy link
Member

Thanks, merged in 912892b

@dpgeorge dpgeorge closed this Oct 21, 2019
tannewt added a commit to tannewt/circuitpython that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants