Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32: Fix RMII typo in stm32f405_af.csv #5308

Closed
wants to merge 1 commit into from
Closed

stm32: Fix RMII typo in stm32f405_af.csv #5308

wants to merge 1 commit into from

Conversation

mcauser
Copy link
Contributor

@mcauser mcauser commented Nov 8, 2019

As per discussion: #5286

@dpgeorge
Copy link
Member

dpgeorge commented Nov 8, 2019

Looks good to me, thanks. Can @untitledlt confirm it works?

@mcauser
Copy link
Contributor Author

mcauser commented Nov 8, 2019

The build now runs successfully against master.
Will have to wait until I get home to test on one of my Black VET6 boards

@mcauser mcauser mentioned this pull request Nov 8, 2019
Open
@untitledlt
Copy link

I was able to build and flash successfully. Thanks!

MicroPython v1.11-549-gf2ecfe8b8 on 2019-11-08; MCUDEV STM32F407VE with STM32F407VE
Type "help()" for more information.
>>>
>>> import network
>>> dir(network)
['__class__', '__name__', 'LAN', 'route']

@mcauser
Copy link
Contributor Author

mcauser commented Nov 9, 2019

I didn't have a LAN module to test this with, so I ordered a one of these LAN8720 modules. I'll revisit in a few weeks.

@dpgeorge
Copy link
Member

Ok I'm happy with this change (even if untested), so merged in 258b147

@mcauser if you manage to test it that would be great, please let us know the result.

@dpgeorge dpgeorge closed this Nov 11, 2019
@mcauser mcauser deleted the f405_af branch November 11, 2019 01:21
tannewt added a commit to tannewt/circuitpython that referenced this pull request Sep 9, 2021
@tannewt
Merge pull request micropython#5308 from microDev1/patch
cfc4ed1 
Revert localization of `REPL` messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-stm32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcauser @dpgeorge @untitledlt