extmod/modbluetooth: Prioritise non-scan-result events. #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove existing scan result events from the ringbuf if the ringbuf is full and we're trying to enqueue any other event.
|
Thank you! I've tested this and it works well. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Sep 10, 2021
Add if pre-condition to builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a scan is in progress, the ring buffer can fill up and be saturated with scan result events. As intended, the extra events are dropped. But this isn't great for other events which ideally should take priority over the scan results.
This PR changes the enqueue behavior so that non-scan-result events can remove other scan-result events from the ringbuffer and take their place.