Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Update build instructions in README. #6469

Closed
wants to merge 1 commit into from

Conversation

stinos
Copy link
Contributor

@stinos stinos commented Sep 22, 2020

Make the instructions more complete by documenting all needed steps
for starting from scratch. Also add a section for MSYS2 since the
Travis build uses it as well and it's a good alternative for Cygwin.
Remove the mingw32 reference since it's not readily available anymore
in most Linux distros nor compiles successfully.


Building on Debian/Ubuntu Linux system
---------------------------------------

sudo apt-get install gcc-mingw-w64
sudo apt-get install python3 build-essential gcc-mingw-w64
make -C ../../mpy-cross CROSS_COMPILE=i686-w64-mingw32-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that correct? Doesn't that build mpy-cross for the Windows system, yet in the following line mpy-cross is needed on the host Linux system to build the main Windows MicroPython? So it should be make -C ../../mpy-cross?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point. I didn't test this particular case though so first let me make sure it actually works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I tested a lot of things yesterday an on second thought, this one as well; but where this would not work on a normal linux system I was testing this on WSL, so even though the generated mpy-cross executable was a windows executable WSL shells can run those. Anyway, fixed now, and tested.

Build using:

make -C ../../mpy-cross CROSS_COMPILE=i686-w64-mingw32-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem as above?

Copy link
Contributor Author

@stinos stinos Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the generated executables run on Windows and as such can also run when called from an MSYS2 shell, or Cygwin shell

make CROSS_COMPILE=i686-w64-mingw32-

Or for 64bit:

make -C ../../mpy-cross CROSS_COMPILE=x86_64-w64-mingw32-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same?

Make the instructions more complete by documenting all needed steps
for starting from scratch.  Also add a section for MSYS2 since the
Travis build uses it as well and it's a good alternative for Cygwin.
Remove the mingw32 reference since it's not readily available anymore
in most Linux distros nor compiles successfully.
@dpgeorge
Copy link
Member

Thanks for updating, merged in bada8c9

@dpgeorge dpgeorge closed this Sep 23, 2020
@stinos stinos deleted the windows-readme branch September 23, 2020 12:28
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jun 9, 2022
…n-main

Translations update from Hosted Weblate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants