extmod/nimble: Reset NimBLE BSS in mp_bluetooth_init. #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, each time service registration happened it would do an increasingly large malloc() for service state. See apache/mynewt-nimble#896.
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 11, 2022
Add them as MICROPY_HW_LED_STATUS so that we can share reset code for them. They aren't actually used for the status if another RGB option is available. (But maybe they should be.) Fixes micropython#6717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an issue where each call to gatts_register_services would result in an ever-increasing malloc().
multitests pass on pybd/unix-h4. I am running more combinations now.