Per-thread exceptions #7251
Closed
Per-thread exceptions #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves mp_pending_exception from mp_state_vm_t to mp_state_thread_t. This allows exceptions to be scheduled on a specific thread. Signed-off-by: David Lechner <david@pybricks.com>
dlech
force-pushed
the
per-thread-exception
branch
4 times, most recently
from
ce3d730
to
791c6b7
Compare
This introduces a new macro to get the main thread and uses it to ensure that asynchronous exceptions such as KeyboardInterrupt (CTRL+C) are only scheduled on the main thread. This is more deterministic than being scheduled on a random thread and is more in line with CPython that only allow signal handlers to run on the main thread. Issue: micropython#7026 Signed-off-by: David Lechner <david@pybricks.com>
dlech
force-pushed
the
per-thread-exception
branch
from
791c6b7
to
7ff789f
Compare
|
Thanks for this, it looks good to me, quite clean and straightforward.
Yes that's something that needs separate investigation. It will depend on whether the GIL is enabled or not. Regardless of that, the change here makes a good step forward and resolves #7026. Merged in ca920f7 and 259d9b6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #7026.
I have updated some old patches to the current master branch. We've been using this on the UNIX port for a over a year now. One thing I'm not sure about is what happens when both threads and the scheduler are enabled. Would it be possible for the scheduler run on a different thread and delay the pending exception on the main thread?