mimxrt: Add SDCard support. #7608
Conversation
alphaFred
force-pushed
the
mimxrt/sdcard
branch
2 times, most recently
from
fa30318
to
6a3535a
Compare
|
Looking forward to your review @dpgeorge 😃 |
alphaFred
force-pushed
the
mimxrt/sdcard
branch
from
d56ff25
to
4084cac
Compare
alphaFred
force-pushed
the
mimxrt/sdcard
branch
from
dd80f87
to
2616459
Compare
|
@dpgeorge Please let me know once you are satisfied with the change. I would like to squash and finalise the commit myself before you merge. |
|
@dpgeorge Is there anything we can do to support you in processing this PR. It's holding up other PRs for the family, like Ethernet and SDRAM support. Since they all change similar files, we want to submit them one-by-one, such that they can be merged easily. |
Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
alphaFred
force-pushed
the
mimxrt/sdcard
branch
from
e1533c7
to
c22f8e7
Compare
|
@dpgeorge - fyi I just rebased to current master branch. No changes. Still ready for review 😄 |
Signed-off-by: Damien George <damien@micropython.org>
|
in addition to the comments above, please also rebase on the latest master |
alphaFred
force-pushed
the
mimxrt/sdcard
branch
from
c22f8e7
to
ad5eed1
Compare
|
@dpgeorge if you are happy with the change, let me know. I would like to squash myself. |
|
@dpgeorge we (myself and @robert-hh) ran our tests again, yesterday. The latest changes are also working as intended and all test cases are green. |
|
Apart from the last few minor comments, this would be ready to merge. So feel free to squash. |
alphaFred
force-pushed
the
mimxrt/sdcard
branch
from
8f946e9
to
c6e310d
Compare
|
@dpgeorge - fixed and squashed |
|
@alphaFred one final thing: if you'd like this PR to be merged as-is with no rebase or change then please modify the commit message so it's not in the past tense. In this case the message would be something like: mimxrt/sdcard: Implement SDCard driver. (note "Implement" not "Implemented"). This makes it consistent with other commit messages. |
alphaFred
force-pushed
the
mimxrt/sdcard
branch
from
c6e310d
to
74ba4e4
Compare
- Configures `PLL2->PFD0` with **198MHz** as base clock of
`USDHCx` peripheral.
- Adds guards for SDCard related files via `MICROPY_PY_MACHINE_SDCARD`
- Adds creation of pin defines for SDCard to make-pins.py
- Adds new configuration option for SDCard peripheral pinout
to mpconfigport.h
- Adds interrupt handling support instead of polling
- Adds support for `ADMA2` powered data transfer
- Configures SDCard to run in HS (high-speed mode) with **50MHz** only!
SDCard support is optional and requires `USDHC` peripheral.
Thus this driver is not available on `MIMXRT1010_EVK`.
SDCard support is enabled by setting `MICROPY_PY_MACHINE_SDCARD = 1`
in mpconfigboard.mk.
Signed-off-by: Philipp Ebensberger
alphaFred
force-pushed
the
mimxrt/sdcard
branch
from
74ba4e4
to
87f97e4
Compare
|
Hi @dpgeorge. It looks as if you are very busy, just finding time late at night for a few short actions. All changes including the "final thing" are made, so this PR could be merged, if you find the time. |
Yes, that's right.
Ah, I didn't see it was updated. Usually github sends an email notification for (force-)pushes but apparently not this time. So thanks for the note. Now merged! Thanks for the hard work on this. |
|
Thank you very much. @alphaFred just submitted the next PR. I made another comment there. |
|
Also from my side many thanks. Our PR train just got rolling 😂 we were quite busy over the summer. |
Added SDCard support with driver using USDHC peripheral of MIMXRT chip. SDCard interface is configured 4Bit wide with 50MHz operating frequency.
This change was possible with the untiring efforts of @robert-hh in testing, bugfixing and design decisions. Many thanks.