ports/esp32/mpconfigport.h: Enable reverse/inplace special methods. #7613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
+1
Probably also a good idea, but then rp2 and stm32 would want to follow suit (and for small stm32 builds we'd want to have the option in the board config to turn it off). |
|
Merged in bfc8e88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5897 and https://forum.micropython.org/viewtopic.php?f=3&t=10927&p=60120
Reverse ops are supported on STM32, rp2, etc. Anything that's enabled for STM32 probably should also be on ESP32.
Also added inplace arithmetic. This will be the first port to enable this, but we have the flash space on ESP32.