Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32: Disable computed goto on constrained boards. #7685

Closed
wants to merge 1 commit into from

Conversation

jimmo
Copy link
Member

@jimmo jimmo commented Aug 19, 2021

Saves ~1kiB. Add comment to this effect to mpconfig.h.

I saw CI failures on a PR for L072 due to code size, so this gets a bit of extra headroom.

See #7680 (comment) for some recent benchmarks for computed goto (on M4).

@codecov-commenter
Copy link

Codecov Report

Merging #7685 (c3ac402) into master (44818d1) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7685   +/-   ##
=======================================
  Coverage   98.25%   98.26%           
=======================================
  Files         154      154           
  Lines       20071    20071           
=======================================
+ Hits        19721    19722    +1     
+ Misses        350      349    -1     
Impacted Files Coverage Δ
py/runtime.c 99.24% <0.00%> (-0.16%) ⬇️
py/obj.c 97.61% <0.00%> (ø)
py/objfun.c 100.00% <0.00%> (ø)
py/lexer.c 98.99% <0.00%> (+<0.01%) ⬆️
py/parse.c 99.17% <0.00%> (+0.20%) ⬆️
py/bc.c 89.69% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44818d1...c3ac402. Read the comment docs.

@dpgeorge
Copy link
Member

Build failures on stm32 need to be fixed (it's obvious why they fail).

Saves ~1kiB. Add comment to this effect to mpconfig.h.

Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
@jimmo jimmo force-pushed the stm32-disable-computed-goto branch from c3ac402 to a0aad64 Compare August 19, 2021 13:21
@jimmo
Copy link
Member Author

jimmo commented Aug 19, 2021

Build failures on stm32 need to be fixed (it's obvious why they fail).

Done.

@dpgeorge
Copy link
Member

Merged in b51e7e9

@dpgeorge dpgeorge closed this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants