esp32/modmachine: wake_ext1_pins() returns which EXT1 pins caused wakeup. #7990

karfas · 2021-11-14T10:39:53Z

This had been discussed in the forum => https://forum.micropython.org/viewtopic.php?f=18&t=11272
Is it OK that this is in modmachine.c and not in modesp32 ?

I still need to test this.

karfas · 2021-11-14T12:32:19Z

Fails to build GENERIC_C3 with ESP-IDF 4.4.
I think this is an ESP-IDF bug.

/home/runner/.espressif/tools/riscv32-esp-elf/esp-2021r1-8.4.0/riscv32-esp-elf/bin/../lib/gcc/riscv32-esp-elf/8.4.0/../../../../riscv32-esp-elf/bin/ld: esp-idf/main/libmain.a(modmachine.c.obj): in function `machine_wake_ext1_pins':
/home/runner/work/micropython/micropython/ports/esp32/modmachine.c:220: undefined reference to `esp_sleep_get_ext1_wakeup_status'
collect2: error: ld returned 1 exit status

academo · 2022-02-16T22:02:45Z

I'd love to have this functionality in my project. Is there a way I could compile and test this myself? or merge this PR?

karfas · 2022-02-17T07:48:13Z

Of course, if you are comfortable with GIT and have the environment (e.g. ESP-IDF) to compile micropython.
However, I will create a binary within the next two days or so.

academo · 2022-02-17T12:02:35Z

@karfas much appreciated. I am confident enough with git and I don't have esp-idf but I am sure I can figure how to install it. Is there a guide somewhere I can follow to compile it for the esp32? (maybe I missed it on the docs? I tried to find one)

karfas · 2022-02-17T16:13:58Z

@academo: I don't think there is a complete description in the upy docs. In Linux, the process is (relative) straight:

install ESP-IDF (see https://docs.espressif.com/projects/esp-idf/en/v4.4/esp32s2/get-started/index.html#get-started-get-esp-idf)
clone micropython (+maybe merge the PR).
You might find the generic instructions for building uPy useful => https://docs.micropython.org/en/latest/develop/gettingstarted.html?highlight=compiling
set your environment to use the variables from esp-idf export.sh
(cd micropython/mpy-cross && make)
(cd micropython/ports/esp32 && make)

BTW, the forum https://forum.micropython.org/ is most likely a better place to ask about compilation issues.

karfas · 2022-02-19T18:46:23Z

@academo: I just uploaded the binary including #7990, based upon the current micropython master branch to https://github.com/karfas/upy-bin/blob/master/micropython-GENERIC-ext1_reason.bin
It works (in principle, I didn't try to actually wake the thing from deep sleep) on the esp32-pico-d4.

karfas · 2022-02-19T18:52:27Z

Rebased to current master.

academo · 2022-02-20T15:22:09Z

@karfas I'll give it a try this coming week. I am finishing my current project with c++ and arduino (mainly because of this feature and the pwm problem).

academo · 2022-02-21T12:19:38Z

@karfas I tried today to run your .bin in a generic esp32 dev board and it got stuck in an infinite reboot loop. I fully erased the flash before installing your binary

configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3f400020,len:197324
ets Jun  8 2016 00:22:57

rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3f400020,len:197324
ets Jun  8 2016 00:22:57

rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3f400020,len:197324

... and so on...

I confirmed by reinstalling esp32-20220221-unstable-v1.18-141-gff9c70850.bin which works as expected (no reboot loop)

EDIT:
This was the flashing command and output:

❯ esptool.py --chip esp32 --port /dev/ttyUSB0 write_flash -z 0x1000 micropython-GENERIC-ext1_reason.bin
esptool.py v3.2
Serial port /dev/ttyUSB0
Connecting...........
Chip is ESP32-D0WDQ6 (revision 1)
Features: WiFi, BT, Dual Core, 240MHz, VRef calibration in efuse, Coding Scheme None
Crystal is 40MHz
MAC: [redacted]]
Uploading stub...
Running stub...
Stub running...
Configuring flash size...
Flash will be erased from 0x00001000 to 0x00165fff...
Compressed 1461984 bytes to 989481...
Wrote 1461984 bytes (989481 compressed) at 0x00001000 in 87.4 seconds (effective 133.9 kbit/s)...
Hash of data verified.

academo · 2022-02-21T13:47:09Z

To followup: I build my own firmware.bin and I also get this reboot loop. I guess there's something in master that is broken.

karfas · 2022-02-27T09:09:08Z

@academo: I also get the boot loop when flashing using your esptool.py command.
However, a fresh build (my script uses idf.py ... flash) - gives me a working REPL on the ESP32.
idf.py ... flash uses

esptool.py --chip esp32 -p /dev/ttyUSB0 -b 115200 --before=default_reset --after=hard_reset write_flash --flash_mode dio --flash_freq 40m --flash_size 4MB 0x1000 bootloader/bootloader.bin 0x10000 micropython.bin 0x8000 partition_table/partition-table.bin

this also worked on the command line.

Most likely, I had created the bin in some wrong way.

karfas · 2022-02-27T16:59:04Z

This is now tested and working on my ESP32-D0WDQ6 (revision 1) chip on an ESP32 DevKit V1 board (or clone).
My test program:

import machine
from machine import Pin, TouchPad
import time
import esp32
import esp

if machine.reset_cause() == machine.DEEPSLEEP_RESET:
    print("Reset: Wakeup from deep sleep")
else:
    print("Reset: Other reason")

print("wakeup_reason(): {}".format(machine.wake_ext1_pins()))

pin4 = Pin(4, mode = Pin.IN, pull = Pin.PULL_DOWN)
wake = Pin(2, mode = Pin.IN, pull = Pin.PULL_DOWN)
esp32.wake_on_ext1(pins = [wake,pin4], level = Pin.WAKE_HIGH)

time.sleep(2)
print('Going to sleep')
machine.deepsleep()

returns e.g.

>>> import main1
Reset: Wakeup from deep sleep
wakeup_reason(): (4,)
Going to sleep

or

>>> import main1
Reset: Wakeup from deep sleep
wakeup_reason(): (2, 4)
Going to sleep

For the second test, I connected both inputs to the same button.

karfas · 2022-02-27T17:37:39Z

@robert-hh: Can you test/review this ? It's mostly your code, anyway.

academo · 2022-02-28T13:50:05Z

@karfas can you share me the new bin? I can help you testing in some of my ESP32 dev boards. I

karfas · 2022-03-01T11:08:01Z

@academo: New binary was uploaded to https://github.com/karfas/upy-bin. Flashing worked on two of my test devices.

bai-yi-bai · 2023-02-12T15:15:52Z

I'm sorry for bumping an old post (I've been watching it for some time), but having this functionality would be really excellent. The log automated check did not retain a record of why the build failed in "docs / build". I'm not an expert, but could this mean there was some formatting mistake in the documentation?

github-actions · 2023-04-23T07:53:42Z

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
        rp2:    +0 +0.000% PICO

codecov-commenter · 2023-04-23T08:06:55Z

Codecov Report

Merging #7990 (9544155) into master (9e6885a) will not change coverage.
The diff coverage is n/a.

❗ Current head 9544155 differs from pull request most recent head 7205a66. Consider uploading reports for the commit 7205a66 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #7990   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files         155      155           
  Lines       20549    20549           
=======================================
  Hits        20241    20241           
  Misses        308      308

Impacted Files	Coverage Δ
extmod/machine_mem.c	`25.00% <ø> (ø)`
extmod/machine_pinbase.c	`100.00% <ø> (ø)`
extmod/machine_signal.c	`92.10% <ø> (ø)`
extmod/modbtree.c	`96.98% <ø> (ø)`
extmod/modframebuf.c	`100.00% <ø> (ø)`
extmod/moduasyncio.c	`99.20% <ø> (ø)`
extmod/modubinascii.c	`100.00% <ø> (ø)`
extmod/moducryptolib.c	`91.11% <ø> (ø)`
extmod/moductypes.c	`97.83% <ø> (ø)`
extmod/moduhashlib.c	`100.00% <ø> (ø)`
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Thomas Wenrich <twenrich@gmail.com>

timsweb · 2023-05-18T13:46:25Z

Fails to build GENERIC_C3 with ESP-IDF 4.4. I think this is an ESP-IDF bug.

/home/runner/.espressif/tools/riscv32-esp-elf/esp-2021r1-8.4.0/riscv32-esp-elf/bin/../lib/gcc/riscv32-esp-elf/8.4.0/../../../../riscv32-esp-elf/bin/ld: esp-idf/main/libmain.a(modmachine.c.obj): in function `machine_wake_ext1_pins':
/home/runner/work/micropython/micropython/ports/esp32/modmachine.c:220: undefined reference to `esp_sleep_get_ext1_wakeup_status'
collect2: error: ld returned 1 exit status

I've done some digging as I'd like this feature for a project. The build fails because despite what the docs say, esp_sleep_get_ext1_wakeup_status isn't available because SOC_PM_SUPPORT_EXT_WAKEUP isn't set for the c3. esp_sleep_get_gpio_wakeup_status does work. If you combine this change (swapping out ext1 for gpio) with this one (that uses gpio wake under the hood) you get a micropython build for the c3 that you can wake from deep sleep and tell which pins woke it.

zackees · 2023-06-04T05:38:00Z

I'm hitting this same bug, it's terrible.

projectgus · 2024-03-07T23:52:26Z

This is an automated heads-up that we've just merged a Pull Request
that removes the STATIC macro from MicroPython's C API.

See #13763

A search suggests this PR might apply the STATIC macro to some C code. If it
does, then next time you rebase the PR (or merge from master) then you should
please replace all the STATIC keywords with static.

Although this is an automated message, feel free to @-reply to me directly if
you have any questions about this.

karfas force-pushed the ext1_reason branch 4 times, most recently from 76a7bf3 to 846f08c Compare November 14, 2021 11:44

karfas force-pushed the ext1_reason branch 2 times, most recently from f4ed298 to 5e2fc75 Compare November 16, 2021 17:47

dpgeorge added the port-esp32 label Nov 29, 2021

karfas closed this Jan 22, 2022

karfas deleted the ext1_reason branch January 22, 2022 20:36

karfas restored the ext1_reason branch January 22, 2022 20:40

karfas reopened this Jan 22, 2022

karfas force-pushed the ext1_reason branch from 5e2fc75 to 0d84800 Compare February 19, 2022 18:48

karfas force-pushed the ext1_reason branch from 0d84800 to cfbfe5c Compare February 27, 2022 16:49

karfas force-pushed the ext1_reason branch 2 times, most recently from 737d49a to 8a5d885 Compare February 27, 2022 19:02

karfas force-pushed the ext1_reason branch from 8a5d885 to 73fac42 Compare April 23, 2022 13:15

hueyy mentioned this pull request Nov 22, 2022

ESP32: Expose ext1 wakeup status #6981

Open

karfas force-pushed the ext1_reason branch from 9544155 to 7205a66 Compare April 23, 2023 07:49

karfas force-pushed the ext1_reason branch from 7205a66 to f211c44 Compare May 10, 2023 20:48

esp32/modmachine: Return GPIOs causing wakeup - wake_ext1_pins().

9792334

Signed-off-by: Thomas Wenrich <twenrich@gmail.com>

karfas force-pushed the ext1_reason branch from f211c44 to 9792334 Compare May 10, 2023 20:52

m-cas mentioned this pull request Jan 9, 2024

Implemented GPIO wake-up for ESP32-C3 #13333

Open

Gadgetoid mentioned this pull request Feb 29, 2024

global: Remove the STATIC macro. #13763

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

esp32/modmachine: wake_ext1_pins() returns which EXT1 pins caused wakeup. #7990

esp32/modmachine: wake_ext1_pins() returns which EXT1 pins caused wakeup. #7990

karfas commented Nov 14, 2021 •

edited

karfas commented Nov 14, 2021

academo commented Feb 16, 2022

karfas commented Feb 17, 2022

academo commented Feb 17, 2022

karfas commented Feb 17, 2022

karfas commented Feb 19, 2022

karfas commented Feb 19, 2022

academo commented Feb 20, 2022

academo commented Feb 21, 2022 •

edited

academo commented Feb 21, 2022

karfas commented Feb 27, 2022

karfas commented Feb 27, 2022 •

edited

karfas commented Feb 27, 2022 •

edited

academo commented Feb 28, 2022

karfas commented Mar 1, 2022

bai-yi-bai commented Feb 12, 2023

github-actions bot commented Apr 23, 2023

codecov-commenter commented Apr 23, 2023

timsweb commented May 18, 2023

zackees commented Jun 4, 2023

projectgus commented Mar 7, 2024

esp32/modmachine: wake_ext1_pins() returns which EXT1 pins caused wakeup. #7990

Are you sure you want to change the base?

esp32/modmachine: wake_ext1_pins() returns which EXT1 pins caused wakeup. #7990

Conversation

karfas commented Nov 14, 2021 • edited

karfas commented Nov 14, 2021

academo commented Feb 16, 2022

karfas commented Feb 17, 2022

academo commented Feb 17, 2022

karfas commented Feb 17, 2022

karfas commented Feb 19, 2022

karfas commented Feb 19, 2022

academo commented Feb 20, 2022

academo commented Feb 21, 2022 • edited

academo commented Feb 21, 2022

karfas commented Feb 27, 2022

karfas commented Feb 27, 2022 • edited

karfas commented Feb 27, 2022 • edited

academo commented Feb 28, 2022

karfas commented Mar 1, 2022

bai-yi-bai commented Feb 12, 2023

github-actions bot commented Apr 23, 2023

codecov-commenter commented Apr 23, 2023

Codecov Report

timsweb commented May 18, 2023

zackees commented Jun 4, 2023

projectgus commented Mar 7, 2024

karfas commented Nov 14, 2021 •

edited

academo commented Feb 21, 2022 •

edited

karfas commented Feb 27, 2022 •

edited

karfas commented Feb 27, 2022 •

edited