Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static and memory-mappable .mpy files #8191

Merged
merged 6 commits into from Feb 24, 2022

Conversation

dpgeorge
Copy link
Member

Background

.mpy files are precompiled .py files, built using mpy-cross, that contain compiled bytecode functions (and can also contain machine code). The benefit of using an .mpy file over a .py file is that they are faster to import and take less memory when importing. They are also smaller on disk.

But the real benefit of .mpy files comes when they are frozen into the firmware. This is done by loading the .mpy file during compilation of the firmware and turning it into a set of big C data structures, which are then compiled and downloaded into the ROM of a device. These C data structures can be executed in-place, ie directly from ROM. This makes importing even faster because there is very little to do, and also means such frozen modules take up much less RAM (because their bytecode stays in ROM).

The downside of frozen code is that it requires recompiling and reflashing the entire firmware. This can be a big barrier to entry, slows down development time, and makes it harder to do OTA updates of frozen code (because the whole firmware must be updated).

An often requested feature is dynamic frozen modules where .mpy files are frozen (written) into ROM at runtime, or at least after the firmware has already been flashed. Such a feature would allow freezing and refreezing Python code without building/compiling firmware.

Static and memory-mappable .mpy files

This PR attempts to solve the problem of dynamic frozen modules but in a different way to the existing freezing mechanism. The idea (and what's implemented in this PR) is to rework the .mpy file format so that it consists of data/bytecode which is mostly static and ready to run. Then if these .mpy files are located in flash/ROM which is memory addressable, the .mpy file can be executed in-place.

With this approach there is still a small amount of unpacking and linking of the .mpy file that needs to be done when it's imported, but it's still going to be a lot better than loading an .mpy from disk. In particular it will save a lot of RAM because the bytecode can stay in flash/ROM and be executed from there.

The main trick to make static .mpy files is for qstrs to go through a lookup table to convert from local qstr number in the module to global qstr number in the firmware. That means the bytecode does not need linking/rewriting of qstrs when it's loaded. Instead only a small qstr table needs to be built (and put in RAM) at import time.

In more detail, in the VM what used to be (schematically):

    qst = DECODE_QSTR_VALUE;

is now (schematically):

    idx = DECODE_QSTR_INDEX;
    qst = code_state->fun_bc->qstr_table[idx];

Surprisingly this qstr indirection in the bytecode has only a small impact on VM performance. On PYBv1.0 one measures:

    diff of scores (higher is better)
    N=100 M=100          p0bc ->       p1bc         diff      diff% (error%)
    bm_chaos.py        363.10 ->     361.74 :      -1.36 =  -0.375% (+/-0.00%)
    bm_fannkuch.py      78.19 ->      77.88 :      -0.31 =  -0.396% (+/-0.00%)
    bm_fft.py         2570.96 ->    2543.43 :     -27.53 =  -1.071% (+/-0.00%)
    bm_float.py       5836.26 ->    5937.80 :    +101.54 =  +1.740% (+/-0.01%)
    bm_hexiom.py        48.30 ->      47.12 :      -1.18 =  -2.443% (+/-0.01%)
    bm_nqueens.py     4460.11 ->    4395.46 :     -64.65 =  -1.450% (+/-0.00%)
    bm_pidigits.py     646.59 ->     649.52 :      +2.93 =  +0.453% (+/-0.54%)
    misc_aes.py        417.04 ->     411.82 :      -5.22 =  -1.252% (+/-0.01%)
    misc_mandel.py    3562.82 ->    3557.88 :      -4.94 =  -0.139% (+/-0.01%)
    misc_pystone.py   2421.36 ->    2355.83 :     -65.53 =  -2.706% (+/-0.01%)
    misc_raytrace.py   378.48 ->     375.83 :      -2.65 =  -0.700% (+/-0.01%)
    viper_call0.py     576.70 ->     576.79 :      +0.09 =  +0.016% (+/-0.02%)
    viper_call1a.py    550.37 ->     550.30 :      -0.07 =  -0.013% (+/-0.01%)
    viper_call1b.py    438.24 ->     436.01 :      -2.23 =  -0.509% (+/-0.00%)
    viper_call1c.py    442.84 ->     441.30 :      -1.54 =  -0.348% (+/-0.22%)
    viper_call2a.py    536.31 ->     536.26 :      -0.05 =  -0.009% (+/-0.00%)
    viper_call2b.py    382.34 ->     378.46 :      -3.88 =  -1.015% (+/-0.11%)

What's done in this PR is the reworking of .mpy files. What is yet to come is being able to store them in flash and import them directly.

Summary

This PR reworks the .mpy file format to be simpler and allow .mpy files to be executed in-place. Performance is not impacted much. Eventually it will be possible to store such .mpy files in a linear, read-only, memory-mappable filesystem so they can be executed from flash/ROM. This will essentially be able to replace frozen code for most applications, making it much simpler to take advantage of memory savings from frozen code.

@dpgeorge
Copy link
Member Author

As part of this, mpy-tool.py now has a proper dump function to inspect .mpy files. Eg, dumping ports/minimal/frozentest.mpy:

frozentest dump

The colours are:

  • grey - meta data (eg sizes)
  • red - qstr data
  • purple - const object data (eg long strings)
  • cyan - static bytecode

All the red, purple and cyan data can be used as-is, ie from flash. So the vast majority of this .mpy file is already ready to run. The main thing to do when importing is to construct the qstr table (here it has 5 entries, so 10 bytes) and create the mp_obj_module_t object to wrap the whole thing up.

@dpgeorge dpgeorge force-pushed the py-static-mpy-files branch 4 times, most recently from e9369cc to 0f6a102 Compare January 22, 2022 12:09
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #8191 (d82978d) into master (ff9c708) will decrease coverage by 0.05%.
The diff coverage is 98.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8191      +/-   ##
==========================================
- Coverage   98.45%   98.39%   -0.06%     
==========================================
  Files         153      153              
  Lines       20153    20176      +23     
==========================================
+ Hits        19842    19853      +11     
- Misses        311      323      +12     
Impacted Files Coverage Δ
py/frozenmod.c 100.00% <ø> (ø)
py/nativeglue.c 94.38% <ø> (ø)
py/obj.h 100.00% <ø> (ø)
py/bc.c 81.45% <85.71%> (-6.90%) ⬇️
py/persistentcode.c 97.26% <96.15%> (-1.10%) ⬇️
py/bc.h 100.00% <100.00%> (ø)
py/builtinevex.c 100.00% <100.00%> (ø)
py/builtinimport.c 98.92% <100.00%> (+0.01%) ⬆️
py/compile.c 99.94% <100.00%> (+<0.01%) ⬆️
py/emit.h 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9c708...d82978d. Read the comment docs.

@dpgeorge dpgeorge force-pushed the py-static-mpy-files branch 5 times, most recently from 61169ce to fa4b80e Compare January 25, 2022 07:38
@dpgeorge dpgeorge force-pushed the py-static-mpy-files branch 5 times, most recently from 086a1fc to 1147870 Compare February 17, 2022 02:00
@dpgeorge dpgeorge changed the title Static and memory-mappable .mpy files (WIP) Static and memory-mappable .mpy files Feb 17, 2022
@dpgeorge dpgeorge force-pushed the py-static-mpy-files branch 4 times, most recently from 26f1957 to 12ccf71 Compare February 23, 2022 07:58
Background: .mpy files are precompiled .py files, built using mpy-cross,
that contain compiled bytecode functions (and can also contain machine
code). The benefit of using an .mpy file over a .py file is that they are
faster to import and take less memory when importing.  They are also
smaller on disk.

But the real benefit of .mpy files comes when they are frozen into the
firmware.  This is done by loading the .mpy file during compilation of the
firmware and turning it into a set of big C data structures (the job of
mpy-tool.py), which are then compiled and downloaded into the ROM of a
device.  These C data structures can be executed in-place, ie directly from
ROM.  This makes importing even faster because there is very little to do,
and also means such frozen modules take up much less RAM (because their
bytecode stays in ROM).

The downside of frozen code is that it requires recompiling and reflashing
the entire firmware.  This can be a big barrier to entry, slows down
development time, and makes it harder to do OTA updates of frozen code
(because the whole firmware must be updated).

This commit attempts to solve this problem by providing a solution that
sits between loading .mpy files into RAM and freezing them into the
firmware.  The .mpy file format has been reworked so that it consists of
data and bytecode which is mostly static and ready to run in-place.  If
these new .mpy files are located in flash/ROM which is memory addressable,
the .mpy file can be executed (mostly) in-place.

With this approach there is still a small amount of unpacking and linking
of the .mpy file that needs to be done when it's imported, but it's still
much better than loading an .mpy from disk into RAM (although not as good
as freezing .mpy files into the firmware).

The main trick to make static .mpy files is to adjust the bytecode so any
qstrs that it references now go through a lookup table to convert from
local qstr number in the module to global qstr number in the firmware.
That means the bytecode does not need linking/rewriting of qstrs when it's
loaded.  Instead only a small qstr table needs to be built (and put in RAM)
at import time.  This means the bytecode itself is static/constant and can
be used directly if it's in addressable memory.  Also the qstr string data
in the .mpy file, and some constant object data, can be used directly.
Note that the qstr table is global to the module (ie not per function).

In more detail, in the VM what used to be (schematically):

    qst = DECODE_QSTR_VALUE;

is now (schematically):

    idx = DECODE_QSTR_INDEX;
    qst = qstr_table[idx];

That allows the bytecode to be fixed at compile time and not need
relinking/rewriting of the qstr values.  Only qstr_table needs to be linked
when the .mpy is loaded.

Incidentally, this helps to reduce the size of bytecode because what used
to be 2-byte qstr values in the bytecode are now (mostly) 1-byte indices.
If the module uses the same qstr more than two times then the bytecode is
smaller than before.

The following changes are measured for this commit compared to the
previous (the baseline):
- average 7%-9% reduction in size of .mpy files
- frozen code size is reduced by about 5%-7%
- importing .py files uses about 5% less RAM in total
- importing .mpy files uses about 4% less RAM in total
- importing .py and .mpy files takes about the same time as before

The qstr indirection in the bytecode has only a small impact on VM
performance.  For stm32 on PYBv1.0 the performance change of this commit
is:

diff of scores (higher is better)
N=100 M=100             baseline -> this-commit  diff      diff% (error%)
bm_chaos.py               371.07 ->  357.39 :  -13.68 =  -3.687% (+/-0.02%)
bm_fannkuch.py             78.72 ->   77.49 :   -1.23 =  -1.563% (+/-0.01%)
bm_fft.py                2591.73 -> 2539.28 :  -52.45 =  -2.024% (+/-0.00%)
bm_float.py              6034.93 -> 5908.30 : -126.63 =  -2.098% (+/-0.01%)
bm_hexiom.py               48.96 ->   47.93 :   -1.03 =  -2.104% (+/-0.00%)
bm_nqueens.py            4510.63 -> 4459.94 :  -50.69 =  -1.124% (+/-0.00%)
bm_pidigits.py            650.28 ->  644.96 :   -5.32 =  -0.818% (+/-0.23%)
core_import_mpy_multi.py  564.77 ->  581.49 :  +16.72 =  +2.960% (+/-0.01%)
core_import_mpy_single.py  68.67 ->   67.16 :   -1.51 =  -2.199% (+/-0.01%)
core_qstr.py               64.16 ->   64.12 :   -0.04 =  -0.062% (+/-0.00%)
core_yield_from.py        362.58 ->  354.50 :   -8.08 =  -2.228% (+/-0.00%)
misc_aes.py               429.69 ->  405.59 :  -24.10 =  -5.609% (+/-0.01%)
misc_mandel.py           3485.13 -> 3416.51 :  -68.62 =  -1.969% (+/-0.00%)
misc_pystone.py          2496.53 -> 2405.56 :  -90.97 =  -3.644% (+/-0.01%)
misc_raytrace.py          381.47 ->  374.01 :   -7.46 =  -1.956% (+/-0.01%)
viper_call0.py            576.73 ->  572.49 :   -4.24 =  -0.735% (+/-0.04%)
viper_call1a.py           550.37 ->  546.21 :   -4.16 =  -0.756% (+/-0.09%)
viper_call1b.py           438.23 ->  435.68 :   -2.55 =  -0.582% (+/-0.06%)
viper_call1c.py           442.84 ->  440.04 :   -2.80 =  -0.632% (+/-0.08%)
viper_call2a.py           536.31 ->  532.35 :   -3.96 =  -0.738% (+/-0.06%)
viper_call2b.py           382.34 ->  377.07 :   -5.27 =  -1.378% (+/-0.03%)

And for unix on x64:

diff of scores (higher is better)
N=2000 M=2000        baseline -> this-commit     diff      diff% (error%)
bm_chaos.py          13594.20 ->  13073.84 :  -520.36 =  -3.828% (+/-5.44%)
bm_fannkuch.py          60.63 ->     59.58 :    -1.05 =  -1.732% (+/-3.01%)
bm_fft.py           112009.15 -> 111603.32 :  -405.83 =  -0.362% (+/-4.03%)
bm_float.py         246202.55 -> 247923.81 : +1721.26 =  +0.699% (+/-2.79%)
bm_hexiom.py           615.65 ->    617.21 :    +1.56 =  +0.253% (+/-1.64%)
bm_nqueens.py       215807.95 -> 215600.96 :  -206.99 =  -0.096% (+/-3.52%)
bm_pidigits.py        8246.74 ->   8422.82 :  +176.08 =  +2.135% (+/-3.64%)
misc_aes.py          16133.00 ->  16452.74 :  +319.74 =  +1.982% (+/-1.50%)
misc_mandel.py      128146.69 -> 130796.43 : +2649.74 =  +2.068% (+/-3.18%)
misc_pystone.py      83811.49 ->  83124.85 :  -686.64 =  -0.819% (+/-1.03%)
misc_raytrace.py     21688.02 ->  21385.10 :  -302.92 =  -1.397% (+/-3.20%)

The code size change is (firmware with a lot of frozen code benefits the
most):

       bare-arm:  +396 +0.697%
    minimal x86: +1595 +0.979% [incl +32(data)]
       unix x64: +2408 +0.470% [incl +800(data)]
    unix nanbox: +1396 +0.309% [incl -96(data)]
          stm32: -1256 -0.318% PYBV10
         cc3200:  +288 +0.157%
        esp8266:  -260 -0.037% GENERIC
          esp32:  -216 -0.014% GENERIC[incl -1072(data)]
            nrf:  +116 +0.067% pca10040
            rp2:  -664 -0.135% PICO
           samd:  +844 +0.607% ADAFRUIT_ITSYBITSY_M4_EXPRESS

As part of this change the .mpy file format version is bumped to version 6.
And mpy-tool.py has been improved to provide a good visualisation of the
contents of .mpy files.

In summary: this commit changes the bytecode to use qstr indirection, and
reworks the .mpy file format to be simpler and allow .mpy files to be
executed in-place.  Performance is not impacted too much.  Eventually it
will be possible to store such .mpy files in a linear, read-only, memory-
mappable filesystem so they can be executed from flash/ROM.  This will
essentially be able to replace frozen code for most applications.

Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge merged commit 414b59d into micropython:master Feb 24, 2022
@dpgeorge dpgeorge deleted the py-static-mpy-files branch February 24, 2022 13:14
@@ -31,7 +31,7 @@
#include "py/emitglue.h"

// The current version of .mpy files
#define MPY_VERSION 5
#define MPY_VERSION 6
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are bumping the version here, is it a good time to look at #5807 and/or any other outstanding pull requests that require breaking changes to the .mpy file format?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! There are a few things to do before the next release, to take advantage of this version bump.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean #5807, or something else (maybe to do with dynruntime.h)?

Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just mentioned that one since it was easy to find because I created it. I didn't search further for others.

tannewt added a commit to tannewt/circuitpython that referenced this pull request Jul 27, 2023
displayio: added Mapping to bits_per_value getter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants