Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py/scheduler: Fix race with scheduler and pending exceptions. #8845

Closed
wants to merge 2 commits into from
Closed

py/scheduler: Fix race with scheduler and pending exceptions. #8845

wants to merge 2 commits into from

Commits on Jul 6, 2022

  1. py/scheduler: Fix scheduler race with pending exception. 

    The optimisation that allows a single check in the VM for either a pending
exception or non-empty scheduler queue doesn't work when threading is
enabled, as one thread can clear the sched_state if it has no pending
exception, meaning the thread with the pending exception will never see it.

This removes that optimisation for threaded builds.

Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
    @jimmo
    jimmo committed Jul 6, 2022
    Copy the full SHA
    ebb3af9 View commit details
    Browse the repository at this point in the history

  2. f: review comments 

    Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
    @jimmo
    jimmo committed Jul 6, 2022
    Copy the full SHA
    7d84da0 View commit details
    Browse the repository at this point in the history