rp2/CMakeLists.txt: Check required submodules. #8855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CMakeCache.txt` can exist even if cmake failed. Use `Makefile` instead. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
Ensure that nimble and cyw43-driver are initialised when the board requires it. Also make these work with `make submodules`. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
This supresses a warning from pico-sdk when the board isn't using this driver. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
|
Also don't override |
dpgeorge
reviewed
Jul 5, 2022
| @@ -59,6 +62,9 @@ include(${PICO_SDK_PATH}/pico_sdk_init.cmake) | |||
| # Define the top-level project | |||
| project(${MICROPY_TARGET}) | |||
|
|
|||
| if(MICROPY_BLUETOOTH_NIMBLE) | |||
| endif() | |||
There was a problem hiding this comment.
I think this was added in error, so I removed it during rebase.
RetiredWizard
pushed a commit
to RetiredWizard/micropython
that referenced
this pull request
Mar 27, 2024
…-debouncing Add state integration based debouncing to the `keypad` module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.micropython.org/viewtopic.php?f=3&t=12633
This makes the cmake generation fail if the required submodules (cyw43 and nimble) are not initialised, and also makes
make BOARD=... submodulesfind them.I also found that the cmake output wasn't regenerated after failing, because CMakeCache.txt was present even after failure. So this PR also makes the cmake regeneration conditional on the generated Makefile instead.