usb: Refactor some TinyUSB code from rp2 port to shared/tinyusb.

[projectgus]

• shared/tinyusb holds the MicroPython-specific TinyUSB code that isn't port-specific.
• Updates some of @Molorius' refactoring work from shared/tinyusb: Create for reuse, rp2 only for now. #9357.
• Additional refactors by me, as base for Python-based USB device work in tinyusb: Support USB device drivers written in Python #9497 (some of the changes only really make sense in that context.)
• Additional change to allow building rp2 port with USB device enabled but USB-CDC interface driver disabled.
• In the future, other ports that use TinyUSB (mimxrt, nrf, samd, and maybe esp32) should be able to use shared/tinyusb also.

Testing

Have tested these permutations:

• Default rp2 PICO board config with USB CDC REPL.
• CDC & MSC (MICROPY_HW_USB_MSC 1).
• MSC only (MICROPY_HW_USB_MSC 1, MICROPY_HW_USB_CDC 0).
• USB device, but no CDC & no MSC (MICROPY_HW_USB_MSC 0, MICROPY_HW_USB_CDC 0). This creates a device that reports a single configuration with no interfaces, currently not very useful!
• No USB (MICROPY_HW_ENABLE_USBDEV 0 and MICROPY_HW_ENABLE_UART_REPL 1).

All seems to work as expected.

[projectgus]

@dpgeorge As promised! @jimmo PTAL as well if you have time.

[dpgeorge]

This is MICROPY_HW_USB_MANUFACTURER_STRING in the stm32 port... we should make them the same. I do prefer having STR before the string name, rather than _STRING at the very end. And then I would prefer the full word "MANUFACTURER" because "MANUF" could be confusing to a newcomer.

Well, whatever we go with, it should be consistent across ports.

[projectgus]

@dpgeorge Got it. Looks like I saw this name from mimxrt port, where it was added in commit b73073d.

I'll change to MICROPY_HW_USB_MANUFACTURER_STRING for now. If the mimxrt port changes to use this header in the future, we can always add a compatibility #ifdef to pick up the old macro name.

[dpgeorge]

@Molorius For this file I'm not sure it's correct to add your copyright. This file was simply moved from one location to another, so there's not much added IP.

Do you agree to the removal of this copyright line?

[Molorius]

Yes. If I remember correctly I initially had more functions in here which is why I added my name.

[projectgus]

@dpgeorge Rebased and made some updates including renaming some of the source files, let me know what you think.

[projectgus]

Additional change to allow building rp2 port with USB device enabled but USB-CDC interface driver disabled.

@dpgeorge I can easily put this commit into a separate PR if it's too much to review in one hit, as well.

[robert-hh]

Should I change MICROPY_HW_USB_STR_MANUF to MICROPY_HW_USB_MANUFACTURER_STRING in the mimxrt port. At the moment, these are just local to the mimxrt directory. So it's not urgent and I can put that into the next service pack.

[dpgeorge]

Should I change MICROPY_HW_USB_STR_MANUF to MICROPY_HW_USB_MANUFACTURER_STRING in the mimxrt port

Yes, that would make it consistent with this PR and stm32.

[robert-hh]

Ok. Done.

[dpgeorge]

Merged in eed4eb2 through c8913fd with the following changes:

• removed a copyright line as discussed above
• renamed header include guards to have SHARED_TINYUSB in them, instead of LIB_UTILS
• reverted enabling of MICROPY_HW_ENABLE_UART_REPL (I assume it was done just for testing and accidentally left enabled)

Thanks @projectgus !

[projectgus]

reverted enabling of MICROPY_HW_ENABLE_UART_REPL (I assume it was done just for testing and accidentally left enabled)

Oops, yes indeed! Thanks for cleaning those parts up, @dpgeorge.