Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Linked:Bug3118618} [Adaptive Cards > Action.Toggle Visibility] - Screen Reader is not conveying the 'Expanded/Collapsed' state for the more option button. #8654

Closed
vagpt opened this issue Aug 17, 2023 · 3 comments · Fixed by #8721
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Android Used by accessibility team for scorecard categorization HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D Product-AC
Projects

Comments

@vagpt
Copy link
Collaborator

vagpt commented Aug 17, 2023

Target Platforms

Other

SDK Version

1.0

Application Name

Adaptive Cards

Problem Description

Test Environment:
URL: https://adaptivecards.io/explorer/Action.ToggleVisibility.html
OS Version: 23H2(OS Build 25915.1000)
Browser Version: Edge Dev 117.0.2033.0
Screen Reader: Narrator

Repro Steps:

  1. Open the URL on Edge Dev browser.
  2. Press tab key and navigate to the 'More Option' button under 'Please confirm your data'.
  3. Press enter key and observe the issue.

Actual Result:
While navigating to the 'More Option' button on pressing enter key, screen reader is not conveying the state information as 'Expanded'. It is simply announcing the information about the items present under it.

Expected Result:
Screen reader should convey the state information when user activates the 'More Option' button. It should announce as 'More Option button expanded then it should announce the items present under it.'

User Impact:
Users who rely on screen readers will be affected if screen reader does not announce expand/collapsed state info for the controls present in the Action.toggle visibility screen. Due to this user will get confused and will not get idea that control is getting expanded/collapsed and this may cause distortion.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc=%7B507B5D90-F1B9-4AE1-91D1-2F1F2D6C7C1D%7D&file=MAS%204.1.2%20%E2%80%93%20Name%2C%20Role%2C%20Value.docx&action=default&mobileredirect=true&share=IQGQXXtQufHhSpHRLx8tbHwdAUoz-PLo6lZ2eagKqmDeOGc

Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com).

Screenshots

WCAG4.1.2-.Screen.Reader.is.not.conveying.the.ExpandedCollapsed.state.for.the.more.option.button.mp4

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

@vagpt vagpt added Bug Area-Renderers Area-Accessibility Bugs around feature accessibility A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yWCAG Accessibility issue that affects compliance HCL-E+D Product-AC HCL-AdaptiveCards-Android Used by accessibility team for scorecard categorization HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization labels Aug 17, 2023
@github-actions github-actions bot added this to Not Triaged in Triage Aug 17, 2023
@vagpt
Copy link
Collaborator Author

vagpt commented Aug 17, 2023

This bug can be originally tracked using the URL below.

https://dev.azure.com/domoreexp/MSTeams/_workitems/edit/3118618

Snippet:

image

@jwoo-msft jwoo-msft moved this from Not Triaged to P1 in Triage Aug 21, 2023
@BhargaviAnnadevara
Copy link

Any update on this issue?

@vagpt
Copy link
Collaborator Author

vagpt commented Nov 3, 2023

This issue is working fine on the environment below, hence closing this issue.

Test Environment:
URL: https://adaptivecards.io/explorer/Action.ToggleVisibility.html
OS Version: 23H2(OS Build 25977.1000)
Browser Version: Version 120.0.2186.2 (Official build) dev (64-bit)
Screen Reader: Narrator

kunalnagar pushed a commit to kunalnagarco/action-cve that referenced this issue Feb 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [adaptivecards](https://adaptivecards.io)
([source](https://togithub.com/microsoft/AdaptiveCards)) | [`2.11.3` ->
`3.0.2`](https://renovatebot.com/diffs/npm/adaptivecards/2.11.3/3.0.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/adaptivecards/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/adaptivecards/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/adaptivecards/2.11.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/adaptivecards/2.11.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>microsoft/AdaptiveCards (adaptivecards)</summary>

###
[`v3.0.2`](https://togithub.com/microsoft/AdaptiveCards/releases/tag/adaptivecards%403.0.2):
23.10 JS Renderer Release

[Compare
Source](https://togithub.com/microsoft/AdaptiveCards/compare/56c8e863a093ba24b43a8ff294dcf7153d168dfc...adaptivecards@3.0.2)

### Latest Packages

🎉[JS adaptivecards
3.0.2](https://www.npmjs.com/package/adaptivecards/v/3.0.2)

#### Fixes

-
[microsoft/AdaptiveCards#8574
-
[microsoft/AdaptiveCards#8709
-
[microsoft/AdaptiveCards#8654

###
[`v3.0.1`](https://togithub.com/microsoft/AdaptiveCards/compare/ac010094d2afd0f11a2a442eccf3bde7ed93f388...56c8e863a093ba24b43a8ff294dcf7153d168dfc)

[Compare
Source](https://togithub.com/microsoft/AdaptiveCards/compare/ac010094d2afd0f11a2a442eccf3bde7ed93f388...56c8e863a093ba24b43a8ff294dcf7153d168dfc)

###
[`v3.0.0`](https://togithub.com/microsoft/AdaptiveCards/compare/fd749b7de6db0dc5a5e120831ef97722c334fae2...ac010094d2afd0f11a2a442eccf3bde7ed93f388)

[Compare
Source](https://togithub.com/microsoft/AdaptiveCards/compare/fd749b7de6db0dc5a5e120831ef97722c334fae2...ac010094d2afd0f11a2a442eccf3bde7ed93f388)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kunalnagarco/action-cve).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Android Used by accessibility team for scorecard categorization HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D Product-AC
Projects
Triage
Closed
Development

Successfully merging a pull request may close this issue.

2 participants