-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS] Fix horizontalAlignment parsing bug #2553
Conversation
Added to Action.Submit and Action.Http
CSS updates for visualizer only
Also any way we can push features up separately and into master as you dev them so they dont all get associated with a single PR or one set of multiple commits? just to containerize and serialize commits a bit more? Makes it easy to roll commits back should one be buggy.. it would help us track issues and completeness throughout the milestone leading up to release and not just the day of .. slightly easier to manage...thanks a ton.. |
@dclaux this branch seems good, do you have an ETA when you want to merge it? I just added my review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm seems to be a package-lock.json conflict that's likely blocking merge. @dclaux FYI |
No idea why the NodeJS build is failing. I made no change beside pulling master and it compiles just fine on my machine. I will override this and merge anyway if everyone agrees. |
It should be rare indeed that we override a failing build -- especially when the build is failing for the thing you're authoring. We need to understand why the build failed before we can consider skipping it. @matthidinger -- looks like some failing build stuff here. Do we need updates or refinements to our CI build definition? |
Meanwhile, I'll trigger another build to see if it may be related to problems on the agent. |
/AzurePipelines run |
No pipelines are associated with this pull request. |
Looks like it was a hiccup with the CI job. We should try to understand why the build was flaky. |
It is also somewhat impractical IMO that changes only in the NodeJS path could be blocked by iOS checks for example (or the other way around.) We should consider splitting things up. |
I agree that it's impractical. Unfortunately, as far as I've been able to figure out, checks can be only be marked |
What's with the license/cla check that won't complete? |
Alright, and now another merge for a non-JS-related change has just reset the whole things. Happened twice today already. I am going to forcefully merge my changes now, after pulling the latest from master. |
Implements the following:
All manually tested.