[TS] Fix horizontalAlignment parsing bug

[dclaux]

Implements the following:

• "Primary" and destructive action buttons #861
• fontType property on TextBlock #1078
• Add isRequired to inputs #1978
• Additional built-in container styles #1886
• Bug fixes

All manually tested.

[shalinijoshi19]

Also any way we can push features up separately and into master as you dev them so they dont all get associated with a single PR or one set of multiple commits? just to containerize and serialize commits a bit more? Makes it easy to roll commits back should one be buggy.. it would help us track issues and completeness throughout the milestone leading up to release and not just the day of .. slightly easier to manage...thanks a ton..

[matthidinger]

@dclaux this branch seems good, do you have an ETA when you want to merge it? I just added my review

[paulcam206]

[shalinijoshi19]

Hmm seems to be a package-lock.json conflict that's likely blocking merge. @dclaux FYI

[dclaux]

No idea why the NodeJS build is failing. I made no change beside pulling master and it compiles just fine on my machine. I will override this and merge anyway if everyone agrees.

[paulcam206]

It should be rare indeed that we override a failing build -- especially when the build is failing for the thing you're authoring. We need to understand why the build failed before we can consider skipping it.

@matthidinger -- looks like some failing build stuff here. Do we need updates or refinements to our CI build definition?

[paulcam206]

Meanwhile, I'll trigger another build to see if it may be related to problems on the agent.

[paulcam206]

/AzurePipelines run

[azure-pipelines]

No pipelines are associated with this pull request.

[paulcam206]

Looks like it was a hiccup with the CI job. We should try to understand why the build was flaky.

[dclaux]

It is also somewhat impractical IMO that changes only in the NodeJS path could be blocked by iOS checks for example (or the other way around.) We should consider splitting things up.

[paulcam206]

I agree that it's impractical. Unfortunately, as far as I've been able to figure out, checks can be only be marked required at the branch level, not at the changed-directory level -- so we either live with people checking in build breaks, or we live with having unneeded checks running for all PRs.

[dclaux]

What's with the license/cla check that won't complete?

[dclaux]

Alright, and now another merge for a non-JS-related change has just reset the whole things. Happened twice today already. I am going to forcefully merge my changes now, after pulling the latest from master.