[WPF][InputEvolution] Fix fallback and error messages in non interactive scenarios #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@almedina-ms tx! To confirm, you were able to test this with the 1.2 version of the sample(which is what had been failing? ) |
|
@almedina-ms there are more than test changes here. We should update the description/title to be reflective of that(its a bit confusing right now with "Fux WPF test errors") |
almedina-ms
changed the title
The bug was found with the SimpleFallback card. As stated in the description that card works now |
almedina-ms
added a commit
that referenced
this pull request
Jul 31, 2020
almedina-ms
added a commit
that referenced
this pull request
Jul 31, 2020
* Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com>
almedina-ms
added a commit
that referenced
this pull request
Jul 31, 2020
* Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com>
almedina-ms
added a commit
that referenced
this pull request
Jul 31, 2020
* Fix Fallback and error message with no interactivity (#4502) * Remove unused, untested and consumable function (#4507) * Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
shalinijoshi19
added a commit
that referenced
this pull request
Aug 3, 2020
* Remove unused, untested and consumable function (#4507) * Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Updating version to 2.0.0 for nuget release Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
shalinijoshi19
added a commit
that referenced
this pull request
Aug 3, 2020
* Remove unused, untested and consumable function (#4507) * Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Updating version to 2.0.0 for nuget release Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Fix Fallback and error message with no interactivity (microsoft#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Remove unused, untested and consumable function (microsoft#4507) * Fix Fallback and error message with no interactivity (microsoft#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Updating version to 2.0.0 for nuget release Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4474
Description
This PR includes two fixes:
How Verified
SimpleFallback.json
Inputs (v1.3) with WindowsTimeline host config
Microsoft Reviewers: Open in CodeFlow