-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused, untested and consumable function #4507
Merged
almedina-ms
merged 5 commits into
main
from
user/almedina-ms/IE_RemoveUnusedConfusingCode
Jul 31, 2020
Merged
Remove unused, untested and consumable function #4507
almedina-ms
merged 5 commits into
main
from
user/almedina-ms/IE_RemoveUnusedConfusingCode
Jul 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
changed the title
User/almedina ms/ie remove unused confusing code
Remove unused, untested and consumable function
Jul 31, 2020
golddove
approved these changes
Jul 31, 2020
paulcam206
approved these changes
Jul 31, 2020
almedina-ms
added a commit
that referenced
this pull request
Jul 31, 2020
* Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Merged
almedina-ms
added a commit
that referenced
this pull request
Jul 31, 2020
* Fix Fallback and error message with no interactivity (#4502) * Remove unused, untested and consumable function (#4507) * Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
shalinijoshi19
added a commit
that referenced
this pull request
Aug 3, 2020
* Remove unused, untested and consumable function (#4507) * Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Updating version to 2.0.0 for nuget release Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
shalinijoshi19
added a commit
that referenced
this pull request
Aug 3, 2020
* Remove unused, untested and consumable function (#4507) * Fix Fallback and error message with no interactivity (#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Updating version to 2.0.0 for nuget release Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Fix Fallback and error message with no interactivity (microsoft#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Remove unused, untested and consumable function (microsoft#4507) * Fix Fallback and error message with no interactivity (microsoft#4502) * Remove function that should not be used by customers Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Updating version to 2.0.0 for nuget release Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an extra function that is not used anywhere in the code and is part of Util.java; this function has not been tested and should not be used by our customers.
Microsoft Reviewers: Open in CodeFlow