Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused, untested and consumable function #4507

Merged
merged 5 commits into from
Jul 31, 2020

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Jul 31, 2020

Description

There was an extra function that is not used anywhere in the code and is part of Util.java; this function has not been tested and should not be used by our customers.

Microsoft Reviewers: Open in CodeFlow

@almedina-ms almedina-ms changed the title User/almedina ms/ie remove unused confusing code Remove unused, untested and consumable function Jul 31, 2020
@almedina-ms almedina-ms merged commit 79146b5 into main Jul 31, 2020
@almedina-ms almedina-ms deleted the user/almedina-ms/IE_RemoveUnusedConfusingCode branch July 31, 2020 22:06
almedina-ms added a commit that referenced this pull request Jul 31, 2020
* Fix Fallback and error message with no interactivity (#4502)

* Remove function that should not be used by customers

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
@almedina-ms almedina-ms mentioned this pull request Jul 31, 2020
almedina-ms added a commit that referenced this pull request Jul 31, 2020
* Fix Fallback and error message with no interactivity (#4502)

* Remove unused, untested and consumable function (#4507)

* Fix Fallback and error message with no interactivity (#4502)

* Remove function that should not be used by customers

Co-authored-by: Paul Campbell <paulcam@microsoft.com>

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
shalinijoshi19 added a commit that referenced this pull request Aug 3, 2020
* Remove unused, untested and consumable function (#4507)

* Fix Fallback and error message with no interactivity (#4502)

* Remove function that should not be used by customers

Co-authored-by: Paul Campbell <paulcam@microsoft.com>

* Updating version to 2.0.0 for nuget release

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
shalinijoshi19 added a commit that referenced this pull request Aug 3, 2020
* Remove unused, untested and consumable function (#4507)

* Fix Fallback and error message with no interactivity (#4502)

* Remove function that should not be used by customers

Co-authored-by: Paul Campbell <paulcam@microsoft.com>

* Updating version to 2.0.0 for nuget release

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Fix Fallback and error message with no interactivity (microsoft#4502)

* Remove function that should not be used by customers

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Remove unused, untested and consumable function (microsoft#4507)

* Fix Fallback and error message with no interactivity (microsoft#4502)

* Remove function that should not be used by customers

Co-authored-by: Paul Campbell <paulcam@microsoft.com>

* Updating version to 2.0.0 for nuget release

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants