Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Android] Use ConstraintLayout for Image sizing (#4461)" #4520

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Revert "[Android] Use ConstraintLayout for Image sizing (#4461)" #4520

merged 4 commits into from
Aug 4, 2020

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Aug 3, 2020 •
edited by shalinijoshi19

Related Issue

Fixes #4518

Description

This reverts commit 805c51e.

Up to this point the media element still doesn't work, going back I was able to revert the break by going to commit 1202191 for ImageRenderer

How Verified

TBD

Microsoft Reviewers: Open in CodeFlow

golddove
golddove reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@golddove golddove left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Reverting #4461 seems to fix the media issue when I test it (the one about casting from constraint params). What further issue did you see / what was the fix?

@almedina-ms
Copy link
Contributor Author

Thanks for this.

Reverting #4461 seems to fix the media issue when I test it (the one about casting from constraint params). What further issue did you see / what was the fix?

the other issue was horizontal alignment that is now fixed, but we're missing some testing

@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Aug 3, 2020 •
edited

@almedina-ms this gets CP'd into release/20.07 && release/1.2 as well yeah?

@shalinijoshi19
Copy link
Member

Thanks for this.
Reverting #4461 seems to fix the media issue when I test it (the one about casting from constraint params). What further issue did you see / what was the fix?

the other issue was horizontal alignment that is now fixed, but we're missing some testing

What is the testing here and can we include the test cards in if they aren't already part of the initial fixes?

shalinijoshi19
shalinijoshi19 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@shalinijoshi19 shalinijoshi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shalinijoshi19
Copy link
Member

This needs to be CP'd over to release/1.2 and release/20.07 @almedina-ms thanks

@golddove golddove mentioned this pull request Aug 3, 2020
Merged
@almedina-ms almedina-ms merged commit adb1fc1 into main Aug 4, 2020
@almedina-ms almedina-ms deleted the user/almedina-ms/RevertImageSizingChange branch August 4, 2020 00:37
shalinijoshi19 added a commit that referenced this pull request Aug 4, 2020
@almedina-ms @shalinijoshi19
Revert "[Android] Use ConstraintLayout for Image sizing (#4461)" (#4520)
a33574f 
* Revert "[Android] Use ConstraintLayout for Image sizing (#4461)"

This reverts commit 805c51e.

* Make media work again

* Reset imageview gravity

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
almedina-ms added a commit that referenced this pull request Aug 4, 2020
@shalinijoshi19 @almedina-ms
Revert "[Android] Use ConstraintLayout for Image sizing (#4461)" (#4520…
097ec17 
…) (#4533)

* Revert "[Android] Use ConstraintLayout for Image sizing (#4461)"

This reverts commit 805c51e.

* Make media work again

* Reset imageview gravity

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
golddove added a commit that referenced this pull request Aug 18, 2020
@golddove
Revert "Revert "[Android] Use ConstraintLayout for Image sizing (#4461)…
1a3184a 
…" (#4520)"

This reverts commit adb1fc1.
golddove added a commit that referenced this pull request Aug 24, 2020
@golddove
[Android] Respect both image size and column width (#4613)
fb8460b 
* Revert "Revert "[Android] Use ConstraintLayout for Image sizing (#4461)" (#4520)"

This reverts commit adb1fc1.

* Fix for containers with auto width

* Fix media images

* Switched to xml for clarity

* Refactor, cleanup whitespace

* Fix sample
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@almedina-ms @shalinijoshi19
Revert "[Android] Use ConstraintLayout for Image sizing (microsoft#4461…
efb0e17 
…)" (microsoft#4520)

* Revert "[Android] Use ConstraintLayout for Image sizing (microsoft#4461)"

This reverts commit 6fc552f.

* Make media work again

* Reset imageview gravity

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@golddove
[Android] Respect both image size and column width (microsoft#4613)
f68ae15 
* Revert "Revert "[Android] Use ConstraintLayout for Image sizing (microsoft#4461)" (microsoft#4520)"

This reverts commit efb0e17.

* Fix for containers with auto width

* Fix media images

* Switched to xml for clarity

* Refactor, cleanup whitespace

* Fix sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golddove golddove golddove left review comments

@shalinijoshi19 shalinijoshi19 shalinijoshi19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android][Images are either missing or too small]
3 participants
@almedina-ms @shalinijoshi19 @golddove