[Android] Respect both image size and column width #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
reviewed
Aug 19, 2020
| app:barrierDirection="left" | ||
| app:constraint_referenced_ids="widthPlaceholder" /> | ||
|
|
||
|
|
almedina-ms
reviewed
Aug 24, 2020
| "type": "AdaptiveCard", |
|
Last time there were problems with media and other elements, could you do a quick run across all cards to check that everything is working as expected? |
almedina-ms
approved these changes
Aug 24, 2020
|
Test evidence added to PR description |
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Revert "Revert "[Android] Use ConstraintLayout for Image sizing (microsoft#4461)" (microsoft#4520)" This reverts commit efb0e17. * Fix for containers with auto width * Fix media images * Switched to xml for clarity * Refactor, cleanup whitespace * Fix sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4439
Description
Uses constraint layout to make images grow to the requested size, but not larger than the parent container/column.
How Verified
Manual verification:
v1.2/Tests/ImageSizing.json:ActivityUpdate.json:FlightItinerary.json:ProductVideo.json:Agenda.json:Microsoft Reviewers: Open in CodeFlow