Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema] Add underline to TextRun schema #4559

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Aug 10, 2020

Related Issue

Fixes #4558

Description

Add the Underline property to the TextRun schema for version 1.3

Microsoft Reviewers: Open in CodeFlow

@shalinijoshi19
Copy link
Member

@paulcam206 / @golddove thoughts on the failing Android CI and the "microsoft.AdaptiveCards" checks? Btw do we know what this "microsoft.AdaptiveCards" pipeline is?

@shalinijoshi19
Copy link
Member

@paulcam206 / @golddove thoughts on the failing Android CI and the "microsoft.AdaptiveCards" checks? Btw do we know what this "microsoft.AdaptiveCards" pipeline is?

For the first error looks like it is a "out of disk" issue; @paulcam206 for these in theory re-queueing the job should hopefully pick a better agent yes? Is there a way to report these agents too?

@golddove
Copy link
Member

@shalinijoshi19

Yes, I did rerun the job yesterday and it succeeded. Not sure what exactly went wrong the first time (I remember seeing a 100 minutes timeout issue).

As for the other pipeline, it's related to #4553.

@RebeccaAnne RebeccaAnne mentioned this pull request Aug 14, 2020
@almedina-ms almedina-ms self-requested a review August 14, 2020 22:55
@RebeccaAnne RebeccaAnne merged commit cb73ca4 into main Aug 15, 2020
@RebeccaAnne RebeccaAnne deleted the rebecch/undlineschema branch August 15, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website/SchemaExplorer] Published schema needs to be updated for new 1.3 TextRun.Underline property
4 participants