Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JavaScript] Strings shouldn't be const #4858

Merged
merged 1 commit into from
Sep 30, 2020
Merged

[JavaScript] Strings shouldn't be const #4858

merged 1 commit into from
Sep 30, 2020

Conversation

golddove
Copy link
Member

@golddove golddove commented Sep 30, 2020 •
edited by ghost

Description

Users of the SDK should be able to supply their own strings by modifying these properties.

How Verified

No verification, just restoring previous behavior

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Sep 30, 2020

Hi @golddove. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@golddove golddove merged commit b2d2eef into main Sep 30, 2020
@golddove golddove deleted the golddove/no-const branch September 30, 2020 20:10
golddove added a commit that referenced this pull request Sep 30, 2020
@golddove
[JavaScript] Strings shouldn't be const (#4858)
69106fe
golddove added a commit that referenced this pull request Oct 1, 2020
@golddove @paulcam206
[JavaScript] cherry-pick of #4848 and #4849 for release/20.09 (#4866)
bf9e6eb 
* [JavaScript] Strings shouldn't be const (#4858)

* [JS] Fix arrow keys and actionset aria (#4859)

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
@MYBUSYBEEINC MYBUSYBEEINC mentioned this pull request Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dclaux dclaux dclaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@golddove @dclaux