[JS] Fix arrow keys and actionset aria #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
added
Platform-JavaScript
|
Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
golddove
approved these changes
Sep 30, 2020
dclaux
approved these changes
Sep 30, 2020
golddove
pushed a commit
that referenced
this pull request
Sep 30, 2020
|
🎉 Handy links: |
paulcam206
added a commit
that referenced
this pull request
Nov 23, 2021
paulcam206
added a commit
that referenced
this pull request
Nov 23, 2021
JeanRoca
pushed a commit
to JeanRoca/AdaptiveCards
that referenced
this pull request
Apr 7, 2022
…tion` (microsoft#6763) Fixes microsoft#6425 Fixes microsoft#6019 Related microsoft#4859
paulcam206
added a commit
that referenced
this pull request
Apr 14, 2022
licanhua
added a commit
that referenced
this pull request
Sep 14, 2022
* Updating Bot Framework links (#6686) Co-authored-by: RahulAmlekar <raamleka@microsoft.com> * Scenario cards + Website indentation fix (#6733) * Changed teams target version to 1.4 * added RTL scenario card * Added scenario card for tooltip and isEnabled * Added order confirmation scenario * Added flight update table scenario * Added restaurant order scenario card * Added app login scenario * Fixed indentation in schema explorer * Testing application login on the samples page * Added extended 1.5 scenario cards * Fixed boolean and duplicate id on cards * added flightupdatetable and restaurant order to ignored cards for .NET tests Co-authored-by: Canhua Li <licanhua@live.com> * Removing "Preview" from Viva Connections (#6791) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Added blog posts for oct and nov (#6873) * Changed teams target version to 1.4 * Added october and november blog posts * fixed emojis * testing font weights for emoji * removed bold from emojis as not required to render Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> * make columnsets clickable (#7042) Co-authored-by: Canhua Li <licanhua@live.com> * fix merge conflicts with berlin containers in adaptivecards-designer.ts * Convey Ctrl+M shortcut key to move out of code editor (#7072) * provide hint about ctrl+m toggling tab behavior * rephrase Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> * fixed same merge conflict in another commit * color fix (#7081) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * update headers (#7082) * Add title to iframe component in December 2019 blog post (#7083) * add title * spacing Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * change text color (#7091) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * add aria label (#7090) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * update tab indices accordingly (#7119) Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Adjust contrast on designer peer buttons (#7110) * Update role of 'Select Host App' combobox (#7118) Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Delete old samples that don't have latest features (causing accessibility issues) (#7106) * updates to samples * phone number regex * delete files instead Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * removed carousel samples * fixed merge conflict line 8 of package.json * fix titles (#7130) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * fixed merge conflict in ADCIOSVisualizerUITests * add tooltip on initialization (#7126) * more titles to iframes (#7135) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * add alt text (#7131) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * use active border instead of white (#7122) * add landmark (#7145) * Use HTML lists for hyperlinks (#7127) * Use HTML lists for hyperlinks * consistent spacing in css file Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Add a caption to the table present in the 'help' dialog (#7149) * move keyboard shortcut text to caption * use innerText instead * don't let focus fall on card designer surface (#7153) * add 1 px left margin (#7142) * Add underline styling to hyperlinks (#7157) Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Allow footer hyperlinks to wrap (#7147) Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Website updates (#7163) * Changed teams target version to 1.4 * Added october and november blog posts * fixed emojis * testing font weights for emoji * removed bold from emojis as not required to render * added blogs posts * fixed video titles * updated roadmap links * removed repeated sentence Co-authored-by: Canhua Li <licanhua@live.com> * [JS] Remove `role='menubar'` and `role='menuitem'` from `ActionCollection` (#6763) Fixes #6425 Fixes #6019 Related #4859 * sync loc file * more package-locks * cherry pick 646503b * return focus after closing (#7155) * final cherry picks for 5e0f39f and 67187d0 * update designer * revert package-lock.json changes Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: J.P. Roca <jproca@microsoft.com> Co-authored-by: Siddharth Gulati <62313299+SidGulatiMsft@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Roy Nehoran <rnehoran@gmail.com> Co-authored-by: naramaka <65971640+naramaka@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Will Shown <thure@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com>
licanhua
added a commit
that referenced
this pull request
Sep 15, 2022
* Updating Bot Framework links (#6686) Co-authored-by: RahulAmlekar <raamleka@microsoft.com> * Scenario cards + Website indentation fix (#6733) * Changed teams target version to 1.4 * added RTL scenario card * Added scenario card for tooltip and isEnabled * Added order confirmation scenario * Added flight update table scenario * Added restaurant order scenario card * Added app login scenario * Fixed indentation in schema explorer * Testing application login on the samples page * Added extended 1.5 scenario cards * Fixed boolean and duplicate id on cards * added flightupdatetable and restaurant order to ignored cards for .NET tests Co-authored-by: Canhua Li <licanhua@live.com> * Removing "Preview" from Viva Connections (#6791) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Added blog posts for oct and nov (#6873) * Changed teams target version to 1.4 * Added october and november blog posts * fixed emojis * testing font weights for emoji * removed bold from emojis as not required to render Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> * make columnsets clickable (#7042) Co-authored-by: Canhua Li <licanhua@live.com> * fix merge conflicts with berlin containers in adaptivecards-designer.ts * Convey Ctrl+M shortcut key to move out of code editor (#7072) * provide hint about ctrl+m toggling tab behavior * rephrase Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> * fixed same merge conflict in another commit * color fix (#7081) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * update headers (#7082) * Add title to iframe component in December 2019 blog post (#7083) * add title * spacing Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * change text color (#7091) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * add aria label (#7090) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * update tab indices accordingly (#7119) Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Adjust contrast on designer peer buttons (#7110) * Update role of 'Select Host App' combobox (#7118) Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Delete old samples that don't have latest features (causing accessibility issues) (#7106) * updates to samples * phone number regex * delete files instead Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * removed carousel samples * fixed merge conflict line 8 of package.json * fix titles (#7130) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * fixed merge conflict in ADCIOSVisualizerUITests * add tooltip on initialization (#7126) * more titles to iframes (#7135) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * add alt text (#7131) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * use active border instead of white (#7122) * add landmark (#7145) * Use HTML lists for hyperlinks (#7127) * Use HTML lists for hyperlinks * consistent spacing in css file Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Add a caption to the table present in the 'help' dialog (#7149) * move keyboard shortcut text to caption * use innerText instead * don't let focus fall on card designer surface (#7153) * add 1 px left margin (#7142) * Add underline styling to hyperlinks (#7157) Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Allow footer hyperlinks to wrap (#7147) Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Website updates (#7163) * Changed teams target version to 1.4 * Added october and november blog posts * fixed emojis * testing font weights for emoji * removed bold from emojis as not required to render * added blogs posts * fixed video titles * updated roadmap links * removed repeated sentence Co-authored-by: Canhua Li <licanhua@live.com> * [JS] Remove `role='menubar'` and `role='menuitem'` from `ActionCollection` (#6763) Fixes #6425 Fixes #6019 Related #4859 * sync loc file * more package-locks * cherry pick 646503b * return focus after closing (#7155) * final cherry picks for 5e0f39f and 67187d0 * update designer * revert package-lock.json changes Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: J.P. Roca <jproca@microsoft.com> Co-authored-by: Siddharth Gulati <62313299+SidGulatiMsft@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Roy Nehoran <rnehoran@gmail.com> Co-authored-by: naramaka <65971640+naramaka@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Will Shown <thure@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com>
licanhua
added a commit
that referenced
this pull request
Sep 15, 2022
#7873) * Merge website march22 to main branch (#7857) * Updating Bot Framework links (#6686) Co-authored-by: RahulAmlekar <raamleka@microsoft.com> * Scenario cards + Website indentation fix (#6733) * Changed teams target version to 1.4 * added RTL scenario card * Added scenario card for tooltip and isEnabled * Added order confirmation scenario * Added flight update table scenario * Added restaurant order scenario card * Added app login scenario * Fixed indentation in schema explorer * Testing application login on the samples page * Added extended 1.5 scenario cards * Fixed boolean and duplicate id on cards * added flightupdatetable and restaurant order to ignored cards for .NET tests Co-authored-by: Canhua Li <licanhua@live.com> * Removing "Preview" from Viva Connections (#6791) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Added blog posts for oct and nov (#6873) * Changed teams target version to 1.4 * Added october and november blog posts * fixed emojis * testing font weights for emoji * removed bold from emojis as not required to render Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> * make columnsets clickable (#7042) Co-authored-by: Canhua Li <licanhua@live.com> * fix merge conflicts with berlin containers in adaptivecards-designer.ts * Convey Ctrl+M shortcut key to move out of code editor (#7072) * provide hint about ctrl+m toggling tab behavior * rephrase Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> * fixed same merge conflict in another commit * color fix (#7081) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * update headers (#7082) * Add title to iframe component in December 2019 blog post (#7083) * add title * spacing Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * change text color (#7091) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * add aria label (#7090) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * update tab indices accordingly (#7119) Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Adjust contrast on designer peer buttons (#7110) * Update role of 'Select Host App' combobox (#7118) Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Delete old samples that don't have latest features (causing accessibility issues) (#7106) * updates to samples * phone number regex * delete files instead Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * removed carousel samples * fixed merge conflict line 8 of package.json * fix titles (#7130) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * fixed merge conflict in ADCIOSVisualizerUITests * add tooltip on initialization (#7126) * more titles to iframes (#7135) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * add alt text (#7131) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * use active border instead of white (#7122) * add landmark (#7145) * Use HTML lists for hyperlinks (#7127) * Use HTML lists for hyperlinks * consistent spacing in css file Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Add a caption to the table present in the 'help' dialog (#7149) * move keyboard shortcut text to caption * use innerText instead * don't let focus fall on card designer surface (#7153) * add 1 px left margin (#7142) * Add underline styling to hyperlinks (#7157) Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Allow footer hyperlinks to wrap (#7147) Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Website updates (#7163) * Changed teams target version to 1.4 * Added october and november blog posts * fixed emojis * testing font weights for emoji * removed bold from emojis as not required to render * added blogs posts * fixed video titles * updated roadmap links * removed repeated sentence Co-authored-by: Canhua Li <licanhua@live.com> * [JS] Remove `role='menubar'` and `role='menuitem'` from `ActionCollection` (#6763) Fixes #6425 Fixes #6019 Related #4859 * sync loc file * more package-locks * cherry pick 646503b * return focus after closing (#7155) * final cherry picks for 5e0f39f and 67187d0 * update designer * revert package-lock.json changes Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: J.P. Roca <jproca@microsoft.com> Co-authored-by: Siddharth Gulati <62313299+SidGulatiMsft@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Roy Nehoran <rnehoran@gmail.com> Co-authored-by: naramaka <65971640+naramaka@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Will Shown <thure@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> * prefix adaptivecards# for ttpolicy (#7860) * remove dead code searchAndRemoveForbiddenElements * Revert "use active border instead of white (#7122)" (#7874) This reverts commit 68d88fe. Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: J.P. Roca <jproca@microsoft.com> Co-authored-by: Siddharth Gulati <62313299+SidGulatiMsft@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Roy Nehoran <rnehoran@gmail.com> Co-authored-by: naramaka <65971640+naramaka@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Will Shown <thure@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…tion` (microsoft#6763) Fixes microsoft#6425 Fixes microsoft#6019 Related microsoft#4859
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Updating Bot Framework links (microsoft#6686) Co-authored-by: RahulAmlekar <raamleka@microsoft.com> * Scenario cards + Website indentation fix (microsoft#6733) * Changed teams target version to 1.4 * added RTL scenario card * Added scenario card for tooltip and isEnabled * Added order confirmation scenario * Added flight update table scenario * Added restaurant order scenario card * Added app login scenario * Fixed indentation in schema explorer * Testing application login on the samples page * Added extended 1.5 scenario cards * Fixed boolean and duplicate id on cards * added flightupdatetable and restaurant order to ignored cards for .NET tests Co-authored-by: Canhua Li <licanhua@live.com> * Removing "Preview" from Viva Connections (microsoft#6791) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Added blog posts for oct and nov (microsoft#6873) * Changed teams target version to 1.4 * Added october and november blog posts * fixed emojis * testing font weights for emoji * removed bold from emojis as not required to render Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> * make columnsets clickable (microsoft#7042) Co-authored-by: Canhua Li <licanhua@live.com> * fix merge conflicts with berlin containers in adaptivecards-designer.ts * Convey Ctrl+M shortcut key to move out of code editor (microsoft#7072) * provide hint about ctrl+m toggling tab behavior * rephrase Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> * fixed same merge conflict in another commit * color fix (microsoft#7081) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * update headers (microsoft#7082) * Add title to iframe component in December 2019 blog post (microsoft#7083) * add title * spacing Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * change text color (microsoft#7091) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * add aria label (microsoft#7090) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * update tab indices accordingly (microsoft#7119) Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Adjust contrast on designer peer buttons (microsoft#7110) * Update role of 'Select Host App' combobox (microsoft#7118) Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Delete old samples that don't have latest features (causing accessibility issues) (microsoft#7106) * updates to samples * phone number regex * delete files instead Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * removed carousel samples * fixed merge conflict line 8 of package.json * fix titles (microsoft#7130) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * fixed merge conflict in ADCIOSVisualizerUITests * add tooltip on initialization (microsoft#7126) * more titles to iframes (microsoft#7135) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * add alt text (microsoft#7131) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * use active border instead of white (microsoft#7122) * add landmark (microsoft#7145) * Use HTML lists for hyperlinks (microsoft#7127) * Use HTML lists for hyperlinks * consistent spacing in css file Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Add a caption to the table present in the 'help' dialog (microsoft#7149) * move keyboard shortcut text to caption * use innerText instead * don't let focus fall on card designer surface (microsoft#7153) * add 1 px left margin (microsoft#7142) * Add underline styling to hyperlinks (microsoft#7157) Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * Allow footer hyperlinks to wrap (microsoft#7147) Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Website updates (microsoft#7163) * Changed teams target version to 1.4 * Added october and november blog posts * fixed emojis * testing font weights for emoji * removed bold from emojis as not required to render * added blogs posts * fixed video titles * updated roadmap links * removed repeated sentence Co-authored-by: Canhua Li <licanhua@live.com> * [JS] Remove `role='menubar'` and `role='menuitem'` from `ActionCollection` (microsoft#6763) Fixes microsoft#6425 Fixes microsoft#6019 Related microsoft#4859 * sync loc file * more package-locks * cherry pick 646503b * return focus after closing (microsoft#7155) * final cherry picks for 5e0f39f and 67187d0 * update designer * revert package-lock.json changes Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: J.P. Roca <jproca@microsoft.com> Co-authored-by: Siddharth Gulati <62313299+SidGulatiMsft@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Roy Nehoran <rnehoran@gmail.com> Co-authored-by: naramaka <65971640+naramaka@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Will Shown <thure@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: root <root@PC-cazamor.redmond.corp.microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes VSO 23940376
Description
Two, two, two fixes in one! #4828 regressed arrow keys in key handlers since the keys are referred to as
Arrow[Up|Down], not[Up|Down]. This broke keyboard accessibility in the Designer's toolbar pickers, since you couldn't arrow through the list of options. We also fix up the aria aroundActionSets as well as the dropdown list. Narrator now correctly reads both the expanded/collapsed state ofAction.ShowCardbuttons as well as their positions in the list of actions.How Verified
Microsoft Reviewers: Open in CodeFlow