Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Accessibility] Fix Inputs not receiving focus #5028

Merged
merged 6 commits into from
Nov 4, 2020

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Nov 3, 2020

Related Issue

Fixes #5020

Description

  • Input.Date and Input.Time: removes the calls to not allow focus into the inputs
  • Input.ChoiceSet (compact): changes the behaviour of default placeholders to have at minimum a single space, otherwise the element cannot gain focus. Also fixes talkback not working when the required property was set to true in these elements.

How Verified

The fix was verified manually:

  • Input.Time
    Input Time

  • Input.Date
    Input Date

  • Input.ChoiceSet
    Input ChoiceSet

Microsoft Reviewers: Open in CodeFlow

@almedina-ms almedina-ms merged commit 3c14806 into main Nov 4, 2020
@almedina-ms almedina-ms deleted the golddove/5014 branch November 4, 2020 01:06
almedina-ms added a commit that referenced this pull request Nov 4, 2020
* Allow focus

* Add fix for compact choicesets

* Update input layout to support layouts with spinners

* Replace lines for premade method

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
almedina-ms added a commit that referenced this pull request Nov 4, 2020
* [Android][Accessibility] Fix Inputs not receiving focus (#5028)

* Allow focus

* Add fix for compact choicesets

* Update input layout to support layouts with spinners

* Replace lines for premade method

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>

* Fix basic behaviour (#5029)

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Allow focus

* Add fix for compact choicesets

* Update input layout to support layouts with spinners

* Replace lines for premade method

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants