Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix input.text with inline actions #5029

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Nov 4, 2020

Related Issue

Fixes #5021

Description

Fixes visual cues for Input.Text with inline actions as they represent a special case of an input that doesn't set its accessibility properties in the same place the visual cues render.

How Verified

The fix was verified manually

  • Input.Text with Inline actions
    image

  • Verification that ChoiceSet elements work as expected
    ChoicesetVisualCues

Microsoft Reviewers: Open in CodeFlow

@almedina-ms
Copy link
Contributor Author

/azp run AdaptiveCards-.NET-PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@almedina-ms almedina-ms merged commit be68c1a into main Nov 4, 2020
@almedina-ms almedina-ms deleted the user/almedina-ms/FixInputTextwithInlineActions branch November 4, 2020 02:24
almedina-ms added a commit that referenced this pull request Nov 4, 2020
almedina-ms added a commit that referenced this pull request Nov 4, 2020
* [Android][Accessibility] Fix Inputs not receiving focus (#5028)

* Allow focus

* Add fix for compact choicesets

* Update input layout to support layouts with spinners

* Replace lines for premade method

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>

* Fix basic behaviour (#5029)

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android][UX] [Input validation error UX does not working with inline actions]
2 participants