Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Update node dependencies #5798

Merged
merged 1 commit into from
May 6, 2021
Merged

[JS] Update node dependencies #5798

merged 1 commit into from
May 6, 2021

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented May 6, 2021

This is the set of changes for main -- I should have a set incoming for release/21.04 shortly if they're not directly cherry-pickable.

Note that this includes a major version upgrade to lerna@4.0.0. The breaking changes don't appear to have impacts to us as CLI consumers, but it's probably worth keeping an eye on.

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented May 6, 2021

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206 paulcam206 enabled auto-merge (squash) May 6, 2021 19:15
@paulcam206 paulcam206 merged commit aa1fcc3 into main May 6, 2021
Copy link
Contributor

@jonmill jonmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulcam206 paulcam206 deleted the paulcam/latest-node-deps branch May 6, 2021 21:02
paulcam206 added a commit that referenced this pull request May 6, 2021
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants