-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle input in c++/winrt! #6303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only minor nits - this looks really good! can't wait for everything else to be switched over
Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness. |
Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness. |
* Toggle input in c++/winrt! (microsoft#6303) * Toggle input in c++/winrt! * PR Feedback * Fix return value * Merge Jonwis' object model conversion into UWP (microsoft#6322) * Merge u/jonwis/winui3 from fork * Copy object model changes from winappsdk to uwp * Delete winappsdk directory * Rename WinUI3 to Uwp - everything builds * Testing, bug fixes, and cleanup * Fix propert_opt setter * Version and package changes * Remove nuget source from nuget config * version changes * Update package pushing readme Co-authored-by: Jon Wiswall <jonwis@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> * [Designer] Make everything accessible at high zoom levels (microsoft#6320) * [Designer] Make small-x-dimension scenario basically work Fixes microsoft#6263 * Tabs feedback * Fix drag/drop and random scrolling * Per triage, Xamarin is deprecated, so no need to hold on to this old unsupported code (microsoft#6255) * [Shared] Add `password` `Input.Text` support (microsoft#6377) * [Shared] Add `password` `Input.Text` support Fixes microsoft#6340 * PR feedback * [iOS] removed custom background color to return to system default (microsoft#6378) * [iOS] Updated Radio Buttons / Check Boxes Contrast Ratio (microsoft#6372) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Set wrapping to true for accessibility fix (microsoft#6324) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Fix link traversal (microsoft#6317) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [iOS] Updated vertical content alignment, height and toggle Visibility (microsoft#6329) * [iOS] Fixed microsoft#6219 * [iOS] adding padding support to toggle visibility * [Padding] Update * [iOS] work in progress * mostly done need to refactor and update padding management code * [iOS] refactored * [iOS] added padding test * refactored the padding configuration in FactSet to Padding Handler * [iOS] Updated VerticalContentAlignment and Height * Reverts samples card changes * [iOS] code clean-up * [iOS] CR update * [iOS] CR update * Add implementation and tests (microsoft#6406) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [UWP] Fix risky cast in `GenerateElementProjection()` (microsoft#6412) * [UWP] Fix risky cast in `GenerateElementProjection()` Fixes microsoft#6394 * Fix PR feedback * Fix style behaviour (microsoft#6419) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [JS] Add Password support to Input.Text (microsoft#6407) * Add Password to style list * Fix comparator * Change property implementation to contain version info in new enum value Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [iOS] Password Masking (microsoft#6411) * [iOS] Password implementation * [iOS] Updated unit tests and added sample json * Update Input.Text.PasswordStyle.json Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> * [iOS] Table Horizontal Alignment Update (microsoft#6401) * [iOS] Fixed microsoft#6219 * [iOS] adding padding support to toggle visibility * [Padding] Update * [iOS] work in progress * mostly done need to refactor and update padding management code * [iOS] refactored * [iOS] added padding test * refactored the padding configuration in FactSet to Padding Handler * [iOS] Updated VerticalContentAlignment and Height * Reverts samples card changes * [iOS] code clean-up * [iOS] Table Update * [iOS] Updated Table with better Horizontal Alignment Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [iOS/Android/UWP/Shared] Fix handling of orphaned table child elements (microsoft#6408) * [Shared] Fix parsing of `TableRow` and `TableCell` outside of `Table` Fixes microsoft#6393 * SWIG updates * Fix up Android rendering * Fix up iOS * Fix up UWP Co-authored-by: Paul Campbell <paulcam@paulcam-mac.local> * Enabling blank issues for internal team use (microsoft#6445) Co-authored-by: RebeccaAnne <rebecch@microsoft.com> Co-authored-by: Jon Wiswall <jonwis@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Paul Campbell <paulcam@paulcam-mac.local> Co-authored-by: Jonathan Miller <jonmil@microsoft.com>
* Toggle input in c++/winrt! * PR Feedback * Fix return value
Related Issue
Fixes #6301
Description
Converted the AdaptiveToggleInputRenderer to cpp/winrt.
There are still a few rough edges where the new cpp/winrt code bumps into the existing WRL code.
Sample Card
Looking forward towards #5653 I have moved an updated version of the basic element card for Input.Toggle into a consolidated elements folder under samples. It is not my intent that this will be a long term folder hierarchy, but just working towards starting to build that single pile of element cards that are updated to our latest features.
How Verified
Microsoft Reviewers: Open in CodeFlow