[UWP] Fix risky cast in GenerateElementProjection()
#6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo-msft
approved these changes
Sep 27, 2021
licanhua
reviewed
Sep 28, 2021
almedina-ms
approved these changes
Sep 28, 2021
licanhua
approved these changes
Sep 28, 2021
vivekvijayakrishnan
added a commit
to BigThinkcode/AdaptiveCards
that referenced
this pull request
Sep 30, 2021
* Toggle input in c++/winrt! (microsoft#6303) * Toggle input in c++/winrt! * PR Feedback * Fix return value * Merge Jonwis' object model conversion into UWP (microsoft#6322) * Merge u/jonwis/winui3 from fork * Copy object model changes from winappsdk to uwp * Delete winappsdk directory * Rename WinUI3 to Uwp - everything builds * Testing, bug fixes, and cleanup * Fix propert_opt setter * Version and package changes * Remove nuget source from nuget config * version changes * Update package pushing readme Co-authored-by: Jon Wiswall <jonwis@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> * [Designer] Make everything accessible at high zoom levels (microsoft#6320) * [Designer] Make small-x-dimension scenario basically work Fixes microsoft#6263 * Tabs feedback * Fix drag/drop and random scrolling * Per triage, Xamarin is deprecated, so no need to hold on to this old unsupported code (microsoft#6255) * [Shared] Add `password` `Input.Text` support (microsoft#6377) * [Shared] Add `password` `Input.Text` support Fixes microsoft#6340 * PR feedback * [iOS] removed custom background color to return to system default (microsoft#6378) * [iOS] Updated Radio Buttons / Check Boxes Contrast Ratio (microsoft#6372) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Set wrapping to true for accessibility fix (microsoft#6324) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Fix link traversal (microsoft#6317) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [iOS] Updated vertical content alignment, height and toggle Visibility (microsoft#6329) * [iOS] Fixed microsoft#6219 * [iOS] adding padding support to toggle visibility * [Padding] Update * [iOS] work in progress * mostly done need to refactor and update padding management code * [iOS] refactored * [iOS] added padding test * refactored the padding configuration in FactSet to Padding Handler * [iOS] Updated VerticalContentAlignment and Height * Reverts samples card changes * [iOS] code clean-up * [iOS] CR update * [iOS] CR update * Add implementation and tests (microsoft#6406) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [UWP] Fix risky cast in `GenerateElementProjection()` (microsoft#6412) * [UWP] Fix risky cast in `GenerateElementProjection()` Fixes microsoft#6394 * Fix PR feedback * Fix style behaviour (microsoft#6419) Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [JS] Add Password support to Input.Text (microsoft#6407) * Add Password to style list * Fix comparator * Change property implementation to contain version info in new enum value Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [iOS] Password Masking (microsoft#6411) * [iOS] Password implementation * [iOS] Updated unit tests and added sample json * Update Input.Text.PasswordStyle.json Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> * [iOS] Table Horizontal Alignment Update (microsoft#6401) * [iOS] Fixed microsoft#6219 * [iOS] adding padding support to toggle visibility * [Padding] Update * [iOS] work in progress * mostly done need to refactor and update padding management code * [iOS] refactored * [iOS] added padding test * refactored the padding configuration in FactSet to Padding Handler * [iOS] Updated VerticalContentAlignment and Height * Reverts samples card changes * [iOS] code clean-up * [iOS] Table Update * [iOS] Updated Table with better Horizontal Alignment Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [iOS/Android/UWP/Shared] Fix handling of orphaned table child elements (microsoft#6408) * [Shared] Fix parsing of `TableRow` and `TableCell` outside of `Table` Fixes microsoft#6393 * SWIG updates * Fix up Android rendering * Fix up iOS * Fix up UWP Co-authored-by: Paul Campbell <paulcam@paulcam-mac.local> * Enabling blank issues for internal team use (microsoft#6445) Co-authored-by: RebeccaAnne <rebecch@microsoft.com> Co-authored-by: Jon Wiswall <jonwis@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Paul Campbell <paulcam@paulcam-mac.local> Co-authored-by: Jonathan Miller <jonmil@microsoft.com>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [UWP] Fix risky cast in `GenerateElementProjection()` Fixes microsoft#6394 * Fix PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6394
Description
See #6393 and #6394 for more details, but basically, in this instance we were casting an object implemented with formal element class (
TableRowElementorTableCellElement) to an object of typeUnknownElement. This is risky because we're making assumptions about what the shared model is doing. It's possible that we would end up in this scenario if the shared model implemented support for an element type that the UWP renderer had yet to implement.Sample Card
See
StandaloneTableRow.json.How Verified
Microsoft Reviewers: Open in CodeFlow