Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host Config and CSS for Viva Connections #6598

Merged
merged 24 commits into from
Oct 20, 2021
Merged

Host Config and CSS for Viva Connections #6598

merged 24 commits into from
Oct 20, 2021

Conversation

SidGulatiMsft
Copy link
Contributor

@SidGulatiMsft SidGulatiMsft commented Oct 15, 2021 •
edited by ghost

Description

This PR introduces the Host Config JSON and CSS for Viva Connections in Adapative Cards

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Oct 15, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

@licanhua
Copy link
Contributor

If you want to show them in designer, you need to update source/nodejs/adaptivecards-designer/src/adaptivecards-designer.ts too.
This is an example to see the new config #6530. and you can see the new change on : designer for PR 6530

@SidGulatiMsft
Copy link
Contributor Author

@licanhua licanhua, yep, done that now.
Stitching things together.

anindara
anindara suggested changes Oct 18, 2021
View reviewed changes
Copy link

@anindara anindara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost removed the Needs: Author Feedback label Oct 18, 2021
@paulcam206
Copy link
Member

It looks like this has a build failure in the adaptivecards-visualizer package:

adaptivecards-visualizer: src/app.ts(13,42): error TS2307: Cannot find module './containers/viva-connections' or its corresponding type declarations.

The adaptivecards-visualizer project is deprecated and needs to be deleted, but I'm not sure if that will happen before this work needs to be merged, so it might be easier to just make the changes needed to build cleanly.

@SidGulatiMsft
Update adaptivecards-designer.ts
f96da29 
Changing the drop down title to "Viva Connections (Preview)".
paulcam206 added a commit that referenced this pull request Oct 19, 2021
@paulcam206
[JS] Remove old visualizer code
f2718f9 
Needed to fix up the site's dependency on the visualizer CSS (now uses designer's instead). Should help out for #6598.
@paulcam206 paulcam206 mentioned this pull request Oct 19, 2021
Merged
@ghost ghost removed the Needs: Author Feedback label Oct 19, 2021
lynamemi
lynamemi suggested changes Oct 19, 2021
View reviewed changes
samples/HostConfig/viva-connections.json Outdated Show resolved Hide resolved
samples/HostConfig/viva-connections.json Outdated Show resolved Hide resolved
samples/HostConfig/viva-connections.json Outdated Show resolved Hide resolved
samples/HostConfig/viva-connections.json Outdated Show resolved Hide resolved
samples/HostConfig/viva-connections.json Outdated Show resolved Hide resolved
...nodejs/adaptivecards-designer/src/containers/viva-connections/viva-connections-container.css Outdated Show resolved Hide resolved
...nodejs/adaptivecards-designer/src/containers/viva-connections/viva-connections-container.css Outdated Show resolved Hide resolved
...nodejs/adaptivecards-designer/src/containers/viva-connections/viva-connections-container.css Show resolved Hide resolved
samples/HostConfig/viva-connections.json Outdated Show resolved Hide resolved
...nodejs/adaptivecards-designer/src/containers/viva-connections/viva-connections-container.css Outdated Show resolved Hide resolved
@ghost ghost removed the Needs: Author Feedback label Oct 19, 2021
anindara
anindara approved these changes Oct 20, 2021
View reviewed changes
Copy link

@anindara anindara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for the impact this will have on Viva developers

paulcam206 added a commit that referenced this pull request Oct 20, 2021
@paulcam206
[JS] Remove old visualizer code (#6606)
c62d893 
Needed to fix up the site's dependency on the visualizer CSS (now uses designer's instead). Should help out for #6598.
paulcam206
paulcam206 approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code all looks good, had one minor question/clarification on high contrast colors

...nodejs/adaptivecards-designer/src/containers/viva-connections/viva-connections-container.css Show resolved Hide resolved
@paulcam206 paulcam206 merged commit 1678647 into microsoft:main Oct 20, 2021
@lynamemi lynamemi mentioned this pull request Mar 25, 2022
Merged
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@paulcam206 @michaelfarnsworth
[JS] Remove old visualizer code (microsoft#6606)
96d980e 
Needed to fix up the site's dependency on the visualizer CSS (now uses designer's instead). Should help out for microsoft#6598.
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@SidGulatiMsft @michaelfarnsworth
Host Config and CSS for Viva Connections (microsoft#6598)
5bc2029 
* Create viva-connections.json

* Create viva-connections-container.css

* Update viva-connections-container.css

* Create viva-connections-container.ts

* Update index.ts

* Update app.ts

* Update adaptivecards-designer.ts

* Update app.ts

* Update adaptivecards-designer.ts

* Update adaptivecards-designer.ts

Changing the drop down title to "Viva Connections (Preview)".

* using tabs in json

* Update viva-connections.json

* Reverting changes from app.ts

* Update viva-connections.json

* Incorporating the suggestions

* Incorporating the suggestions

* incorporating suggestions

* incorporating suggestions

* spaces to tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

@lynamemi lynamemi lynamemi approved these changes

@licanhua licanhua licanhua approved these changes

@anindara anindara anindara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SidGulatiMsft @licanhua @paulcam206 @lynamemi @anindara