Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Remove old visualizer code #6606

Merged
merged 3 commits into from
Oct 20, 2021
Merged

[JS] Remove old visualizer code #6606

merged 3 commits into from
Oct 20, 2021

Conversation

paulcam206
Copy link
Member

Related Issue

Fixes #6605

Description

This is low-pri work, but #6598 will be easier to deal with once the visualizer codebase is gone. Remove old code and update site to deal with change (mainly just needed to steal the designer's outlook CSS instead of the visualizer's).

How Verified

  • local build and test

Needed to fix up the site's dependency on the visualizer CSS (now uses designer's instead). Should help out for #6598.
@paulcam206
Copy link
Member Author

@jwoo-msft / @almedina-ms - need one more review here :)

@paulcam206 paulcam206 added this to In progress in Current Sprint via automation Oct 20, 2021
@paulcam206 paulcam206 moved this from In progress to Review in progress in Current Sprint Oct 20, 2021
Copy link
Contributor

@beervoley beervoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Don't forget to merge up-to-date main!

Current Sprint automation moved this from Review in progress to Reviewer approved Oct 20, 2021
@paulcam206
Copy link
Member Author

LGTM :) Don't forget to merge up-to-date main!

we're set up so that we can't merge without it :shipit:

@beervoley
Copy link
Contributor

LGTM :) Don't forget to merge up-to-date main!

we're set up so that we can't merge without it :shipit:

oho! that's some cool stuff :shipit:

@paulcam206 paulcam206 merged commit c62d893 into main Oct 20, 2021
Current Sprint automation moved this from Reviewer approved to Done Oct 20, 2021
@paulcam206 paulcam206 deleted the paulcam/remove-visualizer branch October 20, 2021 18:56
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Needed to fix up the site's dependency on the visualizer CSS (now uses designer's instead). Should help out for microsoft#6598.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Remove old JS visualizer
3 participants