-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET Templating] Resolve commas added in wrong place #7225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dotnetTemplating
…into dotnetTemplating
anna-dingler
requested review from
jwoo-msft,
almedina-ms,
beervoley,
licanhua and
paulcam206
April 26, 2022 16:27
jwoo-msft
approved these changes
Apr 26, 2022
beervoley
reviewed
Apr 26, 2022
source/dotnet/Library/AdaptiveCards.Templating/AdaptiveCardsTemplateVisitor.cs
Show resolved
Hide resolved
beervoley
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anna-dingler
added a commit
that referenced
this pull request
May 11, 2022
* Update expansion of Boolean expressions * Add unit test * Add test for property that accepts boolean * Resolve extra commas in temaplting output
anna-dingler
added a commit
that referenced
this pull request
May 12, 2022
* Update expansion of Boolean expressions * Add unit test * Add test for property that accepts boolean * Resolve extra commas in temaplting output
paulcam206
added a commit
that referenced
this pull request
May 13, 2022
* [.NET Templating] Update Boolean expression evaluation (#7223) * Update expansion of Boolean expressions * Add unit test * Add test for property that accepts boolean * [.NET Templating] Resolve commas added in wrong place (#7225) * Update expansion of Boolean expressions * Add unit test * Add test for property that accepts boolean * Resolve extra commas in temaplting output * [Templating] Realign platforms on invalid $when behavior (#7432) * Align templating platforms for invalid boolean behavior * Formatting * Add comment for exposing warnings to caller * [Templating] Expose warnings/errors to callers (#7437) * In progress: log warnings * Error log for .NET * Add error logging for NodeJS * Resolve comments on PR * Consolidate ArrayList declarations and fix testing nuget package * Rearrange Expand methods and add comments * Refactor to add the errors to template instance * Update warning message * Get warnings from last template expansion * Add markdown file changes Co-authored-by: Paul Campbell <paulcam@microsoft.com>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Update expansion of Boolean expressions * Add unit test * Add test for property that accepts boolean * Resolve extra commas in temaplting output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6680
Description
Commas were sometimes being added unnecessarily which resulted in invalid JSON. I updated
TemplateVisitor
to only add commas if there is an object prior and another object is about to be added.Sample Card
Card:
Data:
How Verified
Verified manually and with the added unit tests.
Microsoft Reviewers: Open in CodeFlow