[Templating] Realign platforms on invalid $when behavior

[anna-dingler]

Related Issue

Fixes #6630

Description

Realign expected behavior for invalid boolean expressions for $when on JS and .NET Templating platforms.

Scenarios:

• If the given string is not an expression (ex: "$when": "notAnExpression")
• If the given expression is invalid/not found in data (ex: "$when": "${invalidExpression}")

In both scenarios, the $when condition should evaluate to false (drop the element) and issue a warning.

Sample Card

Test 1 - Not an Expression

{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "TextBlock",
            "size": "Medium",
            "weight": "Bolder",
            "text": "${title}",
            "$when": "NotAnExpression"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5"
}

Test 2 - Invalid Expression No Data

{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "TextBlock",
            "size": "Medium",
            "weight": "Bolder",
            "text": "${title}",
            "$when": "${InvalidExpression}"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5"
}

Test 3 - Invalid Expression with Data

Card

{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "TextBlock",
            "size": "Medium",
            "weight": "Bolder",
            "text": "${title}",
            "$when": "${InvalidExpression}"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5"
}

Data

{
   "test": "dummyData"
}

How Verified

Verified manually with adaptivecards-site and WPF Visualizer. I also added test cases to both platforms.

Microsoft Reviewers: Open in CodeFlow

[ghost]

Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

[jwoo-msft]

it looks good, my only reservation is the implementation of warning. I will almost say it is necessary to have this implemented before we make next release since we are changing the behavior, adding the warning will give the dev more flexibility to adapt to our changes.

[anna-dingler]

it looks good, my only reservation is the implementation of warning. I will almost say it is necessary to have this implemented before we make next release since we are changing the behavior, adding the warning will give the dev more flexibility to adapt to our changes.

Thanks for reviewing! I'm working on updating the warning implementation now, so I'll make that PR before making the next release.