[Samples]Update test apps samples #8052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
|
@anna-dingler - did you figure out the issue with the |
No, I wasn't able to figure it out. The crash occurs when we cast the I opened an issue for it #8051 |
almedina-ms
approved these changes
Nov 17, 2022
anna-dingler
added a commit
that referenced
this pull request
Nov 21, 2022
* Add headings to samples mentioned by accessibility team * Add headings to v1.5 samples * Remove duplicates * Move remaining samples to v1.5 * [Samples]Update test apps samples (#8052) * WIP: update project files for samples * Update 1.5 references * Disable scneario testing for .net * Fix android visualizer (#8062) * Resolve PR comments
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Add headings to samples mentioned by accessibility team * Add headings to v1.5 samples * Remove duplicates * Move remaining samples to v1.5 * [Samples]Update test apps samples (microsoft#8052) * WIP: update project files for samples * Update 1.5 references * Disable scneario testing for .net * Fix android visualizer (microsoft#8062) * Resolve PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update test apps to reference the correct file paths for samples.
Added v1.5 samples to the UWP Visualizer since all of the samples have been moved.
How Verified
Verified manually on the UWP Visualizer.
Outstanding Issue
Issue rendering the table element: #8051
Microsoft Reviewers: Open in CodeFlow