[Samples] Add headings to sample cards #8045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi @anna-dingler. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
* WIP: update project files for samples * Update 1.5 references
|
Staleness reset by anna-dingler |
…o anna/addHeadings
…iveCards into anna/addHeadings
anna-dingler
commented
Nov 17, 2022
anna-dingler
commented
Nov 18, 2022
jwoo-msft
approved these changes
Nov 18, 2022
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Add headings to samples mentioned by accessibility team * Add headings to v1.5 samples * Remove duplicates * Move remaining samples to v1.5 * [Samples]Update test apps samples (microsoft#8052) * WIP: update project files for samples * Update 1.5 references * Disable scneario testing for .net * Fix android visualizer (microsoft#8062) * Resolve PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #7607
Description
Add headings to sample cards.
I updated and moved required cards to v1.5 so that we could include
TextBlock.style. AddedTextBlock.headingto all cards already at v1.5 and above.How Verified
Verified on the AdaptiveCards site.
Outstanding issue
Updating to v1.5 exposed a Table rendering issue in UWP - #8051
Microsoft Reviewers: Open in CodeFlow