Fixes OS X issues when attempting to build #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@8W9aG, |
* Cmake does not let you define a target without this outside of the folders scope
* Link directly to the rpclib created by the rpclib submodule
* RPC headers no longer live in this package
* Going to make this a no-op for now, the only way to go around this might be using NSThread
* The format argument doesn’t exist and will break UNIX builds
* MavLinkCom fails to link because this isn’t compiled
8W9aG
force-pushed
the
add-osx-cmake-2
branch
from
ca38524
to
55aa17b
Compare
Closed
|
Nice fixes, thanks. |
|
I had to make some fixes to get Linux build to work, please test to make sure I didn't break anything in the OSX build. Specifically, I moved the EXECUTABLE_OUTPUT_PATH so all binaries are now in cmake/output/bin, and I now include CommonSetup() in the top level CmakeLists.txt so that AIRSIM_ROOT is defined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various issues encountered when attempting to build AirSim for OS X, and borrows some ideas from this PR: #16