docs: rename Microsoft to microsoft #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
reviewed
May 8, 2019
| @@ -160,7 +160,7 @@ Parameter | Description | |||
| `handledAt` | Deprecated. This argument is ignored. Please pass `null`. | |||
| `properties` | Map of string to string: Additional data used to [filter exceptions](https://azure.microsoft.com/documentation/articles/app-insights-api-custom-events-metrics/#properties) in the portal. Defaults to empty. | |||
| `measurements` | Map of string to number: Metrics associated with this page, displayed in Metrics Explorer on the portal. Defaults to empty. | |||
| `severityLevel` | Supported values: [SeverityLevel.ts](https://github.com/Microsoft/ApplicationInsights-JS/blob/master/JavaScript/JavaScriptSDK.Interfaces/Contracts/Generated/SeverityLevel.ts) | |||
| `severityLevel` | Supported values: [SeverityLevel.ts](https://github.com/microsoft/ApplicationInsights-JS/blob/master/JavaScript/JavaScriptSDK.Interfaces/Contracts/Generated/SeverityLevel.ts) | |||
There was a problem hiding this comment.
Can you include more information about this change?
There was a problem hiding this comment.
The github organization was renamed from "Microsoft" to "microsoft", so this change is just a find&replace on this. Some things broke, like travis build badges
There was a problem hiding this comment.
I got the actual change, my question is more related to why changing the org name if is going to break tons of people, how did you figure out the name was updated?
There was a problem hiding this comment.
Other repos had similar PRs (e.g. microsoft/ApplicationInsights-Go#30) that showed up in notifcations. Unsure why the org change happened though.
hectorhdzg
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename travis and github links to solve issues from org rename to microsoft.