Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename Microsoft to microsoft #859

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@markwolff
Copy link
Collaborator

commented May 8, 2019

rename travis and github links to solve issues from org rename to microsoft.

@markwolff markwolff requested review from ramthi, jpiyali, xiao-lix and hectorhdzg May 8, 2019

@@ -160,7 +160,7 @@ Parameter | Description
`handledAt` | Deprecated. This argument is ignored. Please pass `null`.
`properties` | Map of string to string: Additional data used to [filter exceptions](https://azure.microsoft.com/documentation/articles/app-insights-api-custom-events-metrics/#properties) in the portal. Defaults to empty.
`measurements` | Map of string to number: Metrics associated with this page, displayed in Metrics Explorer on the portal. Defaults to empty.
`severityLevel` | Supported values: [SeverityLevel.ts](https://github.com/Microsoft/ApplicationInsights-JS/blob/master/JavaScript/JavaScriptSDK.Interfaces/Contracts/Generated/SeverityLevel.ts)
`severityLevel` | Supported values: [SeverityLevel.ts](https://github.com/microsoft/ApplicationInsights-JS/blob/master/JavaScript/JavaScriptSDK.Interfaces/Contracts/Generated/SeverityLevel.ts)

This comment has been minimized.

Copy link
@hectorhdzg

hectorhdzg May 8, 2019

Contributor

Can you include more information about this change?

This comment has been minimized.

Copy link
@markwolff

markwolff May 8, 2019

Author Collaborator

The github organization was renamed from "Microsoft" to "microsoft", so this change is just a find&replace on this. Some things broke, like travis build badges

This comment has been minimized.

Copy link
@hectorhdzg

hectorhdzg May 8, 2019

Contributor

I got the actual change, my question is more related to why changing the org name if is going to break tons of people, how did you figure out the name was updated?

This comment has been minimized.

Copy link
@markwolff

markwolff May 8, 2019

Author Collaborator

Other repos had similar PRs (e.g. microsoft/ApplicationInsights-Go#30) that showed up in notifcations. Unsure why the org change happened though.

@markwolff markwolff merged commit 329d77b into master May 8, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@markwolff markwolff deleted the markwolff/lowercase_microsoft branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.