Add dotnet MyGet package source #78
Conversation
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
| @@ -19,6 +19,7 @@ | |||
| <add key="nuget.org" value="https://www.nuget.org/api/v2/" /> | |||
| <add key="buildtools" value="https://www.myget.org/F/dotnet-buildtools/" /> | |||
| <add key="MyGetApplicationInsights" value="https://www.myget.org/F/applicationinsights" /> | |||
| <add key="dotnet" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" protocolVersion="3" /> | |||
There was a problem hiding this comment.
why do we need this? Can we limit the use to only use officially released packages?
There was a problem hiding this comment.
I am getting the following error
Unable to resolve 'System.Diagnostics.DiagnosticSource (>= 4.4.0)' for '.NETStandard,Version=v1.3'
DiagnosticSource ver. 4.4 is not on official NuGet yet. I believe this is related to the new correlation/automatic dependency tracking and brought onto us by the new Microsoft.ApplicationInsights.dll
There was a problem hiding this comment.
This error happens during NuGet package restoration; I am not depending on DiagnosticSource 4.4 in my code
There was a problem hiding this comment.
Oh, the new projects picks up the latest Application Insights NuGet from MyGet and it already has @lmolkova changes. Can you please set the max version for the dependency to be 2.3, not 2.4?
There was a problem hiding this comment.
Well, but I do want 2.4 because I want my EventSource telemetry module to target netstandard1.3. AFAIK the change for MS.AI.dll to target netstandard1.3 only went into 2.4 branch?
There was a problem hiding this comment.
Ok. Can you please create an issue similar to this microsoft/ApplicationInsights-dotnet#487 so we will not forget to fix it before 2.4 release
This should hopefully fix the restore issue we have seen with the last build attempt