Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Add dotnet MyGet package source #78

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Add dotnet MyGet package source #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions NuGet.Config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<add key="nuget.org" value="https://www.nuget.org/api/v2/" />
<add key="buildtools" value="https://www.myget.org/F/dotnet-buildtools/" />
<add key="MyGetApplicationInsights" value="https://www.myget.org/F/applicationinsights" />
<add key="dotnet" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" protocolVersion="3" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this? Can we limit the use to only use officially released packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting the following error

Unable to resolve 'System.Diagnostics.DiagnosticSource (>= 4.4.0)' for '.NETStandard,Version=v1.3'

DiagnosticSource ver. 4.4 is not on official NuGet yet. I believe this is related to the new correlation/automatic dependency tracking and brought onto us by the new Microsoft.ApplicationInsights.dll

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error happens during NuGet package restoration; I am not depending on DiagnosticSource 4.4 in my code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, the new projects picks up the latest Application Insights NuGet from MyGet and it already has @lmolkova changes. Can you please set the max version for the dependency to be 2.3, not 2.4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, but I do want 2.4 because I want my EventSource telemetry module to target netstandard1.3. AFAIK the change for MS.AI.dll to target netstandard1.3 only went into 2.4 branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Can you please create an issue similar to this microsoft/ApplicationInsights-dotnet#487 so we will not forget to fix it before 2.4 release

</packageSources>
<disabledPackageSources>
<add key="buildtools" value="true" />
Expand Down