Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jackson Weber <47067795+JacksonWeber@users.noreply.github.com>
  • Loading branch information
hectorhdzg and JacksonWeber committed Jul 7, 2023
1 parent e77488e commit 81186da
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/agent/agentLoader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class AgentLoader {
}
};

let connectionString = process.env[ENV_connectionString];
const connectionString = process.env[ENV_connectionString];
if (connectionString) {
this._instrumentationKey = this._getInstrumentationKey(connectionString);
}
Expand Down
2 changes: 1 addition & 1 deletion src/applicationInsightsConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class ApplicationInsightsConfig implements ApplicationInsightsOptions {
// ApplicationInsightsOptions
public otlpTraceExporterConfig?: OTLPExporterConfig;
public otlpMetricExporterConfig?: OTLPExporterConfig;
public enableAutoCollectExceptions?: boolean;
public enableAutoCollectExceptions?: boolean;
public extendedMetrics: { [type: string]: boolean };
public logInstrumentations?: LogInstrumentationsConfig;
// AzureMonitorOpenTelemetryOptions
Expand Down
6 changes: 3 additions & 3 deletions src/shim/configuration/jsonConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ export class JsonConfig implements ApplicationInsightsOptions {
}
// JSON file
else {
let configFileName = "applicationinsights.json";
let rootPath = path.join(__dirname, "../../../"); // Root of folder (__dirname = ../dist-esm/src)
const configFileName = "applicationinsights.json";
const rootPath = path.join(__dirname, "../../../"); // Root of folder (__dirname = ../dist-esm/src)
let tempDir = path.join(rootPath, configFileName); // default
let configFile = process.env[ENV_CONFIGURATION_FILE];
const configFile = process.env[ENV_CONFIGURATION_FILE];
if (configFile) {
if (path.isAbsolute(configFile)) {
tempDir = configFile;
Expand Down

0 comments on commit 81186da

Please sign in to comment.