Return result objects not json/text for NuGet calls #191
Assignees
Labels
enhancement
New feature or request
Comments
Merged
guyacosta
pushed a commit
that referenced
this issue
Apr 8, 2020
guyacosta
added a commit
that referenced
this issue
Apr 9, 2020
* Major add of unit tests for most commands. Some fixes as a resulting benefit of these new tests to improve the core functionality and handle outlier behavior. * Minor cleanup of unnecessary test dll's in Commands project and update of readme, justrunt docs. * Refactor+ of code structure for technical debt and better result object based support. * Refactor+ of code structure for technical debt and better result object based support. * Rebase commit back into 1.2 * Code cleanup tool to raise hygiene consistency. Unused files removed. * Removed unneccesary file as per PR comments. * Removed unneeded versions of these files which already exists in the desired locations under source\unzipped\simple * Unneccessary files. * Update contains to equals comparison for file format checks. * Update AppInspector.CLI/Program.cs Co-Authored-By: Gabe Stocco <98900+gfs@users.noreply.github.com> * Update AppInspector.CLI/Program.cs Co-Authored-By: Gabe Stocco <98900+gfs@users.noreply.github.com> * Optimiztion to remove unneeded type specific json writers that have same functionality in favor of a general json writer. Removed few space lines and consolidated ResultWriter methods into one. * Set missing defaults for CLIAnalyzeCmdOptions * Fix in path for CLI exe affecting LGTM running unit test * Cast improvements suggestions from PR * removing commented out code * LGTM suggestions hygiene improvements * Update RulesEngine/RuleProcessor.cs Co-Authored-By: Gabe Stocco <98900+gfs@users.noreply.github.com> * Update RulesEngine/RuleProcessor.cs Co-Authored-By: Gabe Stocco <98900+gfs@users.noreply.github.com> * Add Build Tests to Pipeline * Update version.json * Remove warning exclusions; one fix for lgtm and removed unneeded code section for suppression which is not used in this fork of the rulesengine. * Update core-pipeline.yml for Azure Pipelines * Update core-pipeline.yml for Azure Pipelines * Setter default values used rather than ctor; code spacing hygiene fixes; added using statement for Process calls for auto dispose. * CodeMaid final hygiene cleanup * Unit test succeeding locally but not in build; attempt to correct. * Attempt to address devops build dependency issues not seen locally. * dep update * Minor attempts at resolving ado build issue for UnitTest * Create output.txt * Test framework update * Fix #191 made to master added here also. * Fix test execution bugs in pipeline * Revert some dep changes Co-authored-by: Gabe Stocco <98900+gfs@users.noreply.github.com> Co-authored-by: David Alcantar <daalcant@microsoft.com>
|
See the wiki link Key 1.2 Changes for a full description of the 1.2 update containing these improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The initial rollout of NuGet support essentially wrapped the CLI functionality was limited to returning a json or text string for the result. In addition, only text format was supported for many of the commands available. The end goal is to provide a standard calling method with enumerable result objects that can be used by callers as needed or persisted as needed and to separate CLI output formatting needs.
Enhancements:
Provide a result object for calls into the Application.Commands object
Provide options that are more applicable for DLL use i.e. don't take file output paths or console arguments etc. which should only be applicable for CLI use.
The text was updated successfully, but these errors were encountered: