New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2 dev branch #192
1.2 dev branch #192
Conversation
…benefit of these new tests to improve the core functionality and handle outlier behavior.
…e of readme, justrunt docs.
…ct based support.
…ct based support.
Suggest to download and review PR branch in it's entirely due to the size of change. Notes: |
RulesPacker/saveold/ApplicationInspector.CLI.runtimeconfig.json
Outdated
Show resolved
Hide resolved
Co-Authored-By: Gabe Stocco <98900+gfs@users.noreply.github.com>
Co-Authored-By: Gabe Stocco <98900+gfs@users.noreply.github.com>
…ame functionality in favor of a general json writer. Removed few space lines and consolidated ResultWriter methods into one.
This pull request introduces 9 alerts and fixes 3 when merging 451f109 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 9 alerts and fixes 3 when merging d9ba137 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 3 when merging 6717e8a into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 3 when merging f17fb75 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 3 when merging 899f2da into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
…es; added using statement for Process calls for auto dispose.
This pull request introduces 4 alerts and fixes 3 when merging 9583290 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 3 when merging 94fc0e7 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 3 when merging e3c61a7 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 3 when merging 4756e53 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 3 when merging cbed817 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 3 when merging 7041787 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 3 when merging 109fcc9 into 642513b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 3 when merging 68b8607 into 6dca8d1 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 3 when merging 1e80738 into 6dca8d1 - view on LGTM.com new alerts:
fixed alerts:
|
Unit tests Module
• 189 passing tests added covering both NuGet and CLI entry points under separate namespaces/classes
• Improved overall code quality and reporting of invalid args/combinations
Overall Code Structure
• Refactoring+rework for technical debt getting to 1.0 eliminating unused code, renaming, moving to isolate to right project
• *Object results-based support for NuGet callers rather than json/text strings
• *New support for First/Best match options for results (best match elevates higher confidence value matches)
• Separation of CLI vs Operation argument options
• All file output format and writters moved to CLI project
• Cleaner isolation of functionality and readability
• Text and Json output support added for all commands (previously limited to text for all but analyze)
• Better use of inheritance to organize common arguments and override
• Better use of polymorphism for checking arguments
Resolves #191