Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Error if Running a Config Command against a non-extant database #120

Closed
gfs opened this issue Apr 17, 2019 · 1 comment
Closed

Return Error if Running a Config Command against a non-extant database #120

gfs opened this issue Apr 17, 2019 · 1 comment
Assignees
@gfs
Labels
enhancement New feature or request

Comments

@gfs
Copy link
Contributor

gfs commented Apr 17, 2019

There are some commands that deal exclusively with data that has already been collected. If the user attempts one of those commands without having created a database (or having entered the wrong custom path) they just get a null result set.

For example: the config --list-runs command.

Current best idea: Send Log.Warning that the database they proposed didn't exist.

This might not happen, as it does require rewriting the DatabaseManager to check if the file already exists, rather than the openorcreate behavior we currently use.
@gfs gfs added the enhancement New feature or request label Apr 17, 2019
@gfs gfs self-assigned this Apr 17, 2019
@gfs
Copy link
Contributor Author

gfs commented Apr 17, 2019

Contributed by @FritzSandsTM

@gfs gfs added this to the Future milestone Apr 23, 2019
gfs pushed a commit that referenced this issue Apr 23, 2019
Fixes #120
316a210
@gfs gfs closed this as completed Apr 24, 2019
gfs added a commit that referenced this issue Apr 24, 2019
@gfs
Adds a first-run notice informing user of telemetry. (#145)
b130802 
* Adds a first-run reminder about telemetry.

* Improve telemetry opt out message

* Fixes #120

* Updated strings

* Clean up telemetry strings some more

Now use three lines instead of 2 for telemetry info notice.

* Adds a clarifying comment.
@gfs gfs removed this from the Future milestone Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfs gfs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gfs