Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a first-run notice informing user of telemetry. #145

Merged
merged 8 commits into from Apr 24, 2019

Conversation

gfs
Copy link
Contributor

@gfs gfs commented Apr 23, 2019

Open to suggestions on wording. What I've used is This application collects usage data to help us improve Attack Surface Analyzer. For our privacy policy visit: {1}. To disable telemetry run '{0}'.
image

@gfs gfs requested review from scovetta and guyacosta April 23, 2019 04:00
@scovetta
Copy link
Member

Suggest a newline to separate the sentences, and adding the CLI name (args[0]?), e.g.:

This application collects usage data to help us improve Attack Surface Analyzer. 
For our privacy policy visit: {1}.
To disable telemetry run 'AttackSurfaceAnalyzer.exe {0}'.

@gfs
Copy link
Contributor Author

gfs commented Apr 23, 2019

Updated per Mike's suggestions. On windows we print .exe on other platforms we just use "AttackSurfaceAnalyzerCli"
image

gfs and others added 2 commits April 22, 2019 23:40
Now use three lines instead of 2 for telemetry info notice.
@gfs
Copy link
Contributor Author

gfs commented Apr 23, 2019

Screen Shot 2019-04-23 at 10 44 21 AM

Here's the latest iteration. @scovetta does this look good to you?

@gfs
Copy link
Contributor Author

gfs commented Apr 24, 2019

@guydalf can you take a look as well? I updated PRIVACY.md already.

@gfs gfs merged commit b130802 into master Apr 24, 2019
@gfs gfs deleted the gfs/Telemetry-Notice-Cli branch April 24, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants