Exposure control added in k4arecorder #161
Conversation
examples/k4arecorder/main.cpp
Outdated
| { | ||
| throw std::runtime_error("Exposure value range is 1 to -11."); | ||
| } | ||
| absoluteExposureValue = (int32_t)(exp2f((float)exposureValue) * 1000000.0f); |
There was a problem hiding this comment.
since this is c++ we should be using static_cast instead of c style casts
| absoluteExposureValue = (int32_t)(exp2f((float)exposureValue) * 1000000.0f); | |
| absoluteExposureValue = static_cast<int32_t>(exp2f(static_cast<float>(exposureValue)) * 1000000.0f); |
examples/k4arecorder/main.cpp
Outdated
| @@ -320,6 +321,17 @@ int main(int argc, char **argv) | |||
| } | |||
| subordinate_delay_off_master_usec = (uint32_t)delay; | |||
| }); | |||
| cmd_parser.RegisterOption("-e|--exposure-control", | |||
| "Set manual exposure value for the RGB camera (default: auto exposure)", | |||
There was a problem hiding this comment.
Trying to understand. It looks like the user should user put a number after -e? What does that number represent?
There was a problem hiding this comment.
It would probably be good to document the accepted range of values here, instead of just in the error.
examples/k4arecorder/main.cpp
Outdated
| int exposureValue = std::stoi(args[0]); | ||
| if (exposureValue < -11 || exposureValue > 1) | ||
| { | ||
| throw std::runtime_error("Exposure value range is 1 to -11."); |
There was a problem hiding this comment.
What does an exposure of "-11" mean? What about an exposure of "1"?
There was a problem hiding this comment.
It's value for exposure control, which is converted to absolute exposure time.
absoluteExposureValue = static_cast<int32_t>(exp2f(static_cast(exposureValue)) * 1000000.0f);
There was a problem hiding this comment.
if exposureValue = -6 , absoluteExposureValue =15625. What does "30000" mean in this table below? Is final absolute Exposure time 15625 or 30000?
|
Thanks for your fast reply. I wonder if the range from 2500us to 10000us is too big. Is it possible to get a intermediate value like 5000 us for a 50hz power freq? |
Tested on FW 1.5.926614.
Minor change to exposure control code in fastcapture tool.