-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I can't see any warning when downloading a file with a bad MD5 hash #1212
Comments
@JohnRusk are you working with blobs, files, or adlsgen2 blobs? |
Hmmmm interesting. So quick summary of my findings today:
|
In my test I had not enabled AzCopy integration
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Matthew Rayermann <notifications@github.com>
Sent: Saturday, March 16, 2019 10:01:09 AM
To: Microsoft/AzureStorageExplorer
Cc: John Rusk; Mention
Subject: Re: [Microsoft/AzureStorageExplorer] I can't see any warning when downloading a file with a bad MD5 hash (#1212)
Hmmmm interesting. So quick summary of my findings today:
1. If not using AzCopy preview feature, then the download never finished. This is due to a bug in the Storage SDK. So maybe yours finishing despite the bad hash is related to that issue? Hard to tell since I can't repro what you're seeing. If you don't mind, I'll let you know once I have a version of the SDK that contains a fix -> I'll produce a private build of Storage Explorer with it -> you can see if you get the MD5 error.
2. If using AzCopy preview feature, there will never be an error. This is because we didn't enable MD5 checking yet for the AzCopy preview. We'll go ahead and make sure that is enabled for 1.8.0. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FAzureStorageExplorer%2Fissues%2F1212%23issuecomment-473439625&data=02%7C01%7Cjohn.rusk%40microsoft.com%7Cbfebaa4394734532bf5c08d6a9895986%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636882804709102690&sdata=CloHkJ3Fpq3vxLZryIXChIEMWHq8yHEyCjf4T1V92DU%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYsDvmm0A15m-FXeUFOhLIVFLIXDaI4hks5vXAoVgaJpZM4bdlUG&data=02%7C01%7Cjohn.rusk%40microsoft.com%7Cbfebaa4394734532bf5c08d6a9895986%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636882804709112699&sdata=pPLuUrYfJLb%2BlNlvPgc5j%2Fwv%2Fm2XT3KhWN411lr4JFU%3D&reserved=0>.
|
Still waiting on the SDK team to release the fix. In the meantime, in 1.8.0, AzCopy will give errors if the MD5s don't match. Moving to 1.9.0 as I don't think the SDK team will make our release. =/ |
Thanks for the update @MRayermannMSFT.
|
@JohnRusk , when you say we, are you talking about yourself? Also, unfortunately we don't have the option/don't expose an option to disable MD5 (either on a file by file basis, or as an option present in say the download dialog). But it is something we will add when we get to doing settings (which should be soon?). And yep! I am aware of that behavior in 10.0.9. We've reacted accordingly and will always be adding the |
@MRayermannMSFT, sorry, it's not clear from my signature. (Maybe I should fix that). I'm at Microsoft, working on AzCopy v10, and personally wrote the MD5 support. |
We eventually will use AzCopy to replace our JS implementation for stability and performance. If we don't get the SDK fix before we use AzCopy by default, there is not much value to fix this bug. Our current AzCopy behavior is correct already, so won't fix this bug in our JS implementation. |
Storage Explorer Version: 1.6.2
Platform/OS: Windows 10
Architecture: x64
Bug description
I downloaded a file for which I know the MD5 hash is wrong. (I used a different tool to uploaded with, deliberately, the wrong hash). I don't see any warning in the Storage Explorer UI. In "activities" at the bottom of the screen, it says "Downloaded 'badhash.dat' to "C:\users\…\Downloads\…"
Steps to Reproduce
Covered above. Email me if you'd like a SAS pointing to the file in question.
Expected Experience
A visible warning that the file is, or may be, corrupt.
Actual Experience
As above
Additional Context
The text was updated successfully, but these errors were encountered: