Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Action Versions #3872

Closed
wants to merge 4 commits into from
Closed

Conversation

wojciechcloudkubed
Copy link
Contributor

@wojciechcloudkubed wojciechcloudkubed commented Mar 12, 2024

Resolves #3847

What is being addressed

Update GitHub Action Versions to the latest ones

Acceptance criteria

  • All actions are updated to their latest version

Copy link

github-actions bot commented Mar 12, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3645dc5.

♻️ This comment has been updated with latest results.

@wojciechcloudkubed
Copy link
Contributor Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/8249878251 (with refid b5620fe6)

(in response to this comment from @wojciechcloudkubed)

@wojciechcloudkubed wojciechcloudkubed marked this pull request as ready for review March 13, 2024 12:49
@tamirkamara
Copy link
Collaborator

@wojciechcloudkubed There's no point in running a test deployment cycle (like with the / test command) when you update the pr_bot or the tre_deploy* workflows as those run from the main branch.

@wojciechcloudkubed
Copy link
Contributor Author

@wojciechcloudkubed There's no point in running a test deployment cycle (like with the / test command) when you update the pr_bot or the tre_deploy* workflows as those run from the main branch.

What would be the best approach to test it? @tamirkamara

pull_request:
branches:
- main
- 'feature/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marrobi I notice some deviation in linting here. Are these changes ok or is there a linter you would ideally like us to use? cc @wojciechcloudkubed @Danny-Cooke-CK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github Actions are already checked here -

VALIDATE_GITHUB_ACTIONS: true

@marrobi
Copy link
Member

marrobi commented Mar 14, 2024

@wojciechcloudkubed There's no point in running a test deployment cycle (like with the / test command) when you update the pr_bot or the tre_deploy* workflows as those run from the main branch.

What would be the best approach to test it? @tamirkamara

I typically try to check in my fork of the repo. Unless @tamirkamara has a better way to test.

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - suggest test it on a fork before merging.

Copy link
Contributor

@nasaldrops nasaldrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi marrobi deleted the versions/MAT-31 branch June 27, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GitHub Action Versions
5 participants