Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[releases/24.x] Determine maxAllowedObsoleteVersion from config in main #864

Merged

Conversation

aholstrup1
Copy link
Contributor

@aholstrup1 aholstrup1 commented Apr 3, 2024

This pull request backports #856 to releases/24.x

Fixes AB#523764

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->

Determine maxAllowedObsoleteVersion from config in main

Right now it's not possible to backport PRs with 25.0 as an obsolete tag
because we didn't update the config value when we branched:
https://github.com/microsoft/BCApps/actions/runs/8449290970?pr=841

needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#523764](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/523764)
@aholstrup1 aholstrup1 requested a review from a team as a code owner April 3, 2024 08:51
@github-actions github-actions bot added the Build: scripts & configs Build scripts and configuration files label Apr 3, 2024
@aholstrup1 aholstrup1 enabled auto-merge (squash) April 3, 2024 08:52
@github-actions github-actions bot added this to the Version 24.1 milestone Apr 3, 2024
@aholstrup1 aholstrup1 merged commit c98ef8b into releases/24.x Apr 3, 2024
31 of 32 checks passed
@aholstrup1 aholstrup1 deleted the backport/releases/24.x/856/20240403105022 branch April 3, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build: scripts & configs Build scripts and configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants