Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Install Slack App using the Python Slack Adapter Documentation #2878

Closed
apburnie opened this issue Oct 28, 2020 · 14 comments · Fixed by #2968
Closed

Cannot Install Slack App using the Python Slack Adapter Documentation #2878

apburnie opened this issue Oct 28, 2020 · 14 comments · Fixed by #2968
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@apburnie
Copy link

Hi. I am trying to set up a chatbot on Microsoft Azure that users can communicate with through Slack. As a first step, I am trying to get the Microsoft sample to work but am having the following difficulties with the documentation. I would greatly appreciate help on this issue. Thank you in advance.

##Sample Information

Sample Type: \samples
Sample Language: Python
Sample Name: 60.slack-adapter

Describe the bug

The README.md file is incomplete in the following regards:

  • Step 2 of Section Gather required configuration settings for your bot refers to installing the Slack App, but Slack states that this cannot be done without 'one feature or permission scope' first being added. What are the features or permission scopes that should be added?

  • Section Update your Slack app states 'You now need to configure 2 URLs for your app and subscribe to the appropriate events'. I understand one of the URLs is the Ngrok URL, but what is the second URL?

  • Step 1 of Section Update your Slack app states "In the Event Subscriptions tab, fill in the 'Request URL' with the same URL you used in step 1". Given that this is step 1 of the section, what URL is this step referring to?

To Reproduce

Examine the README file at BotBuilder-Samples/samples/python/60.slack-adapter/README.md and attempt to replicate the stated steps.

@apburnie apburnie added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Oct 28, 2020
@anusharr anusharr added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Oct 28, 2020
@v-kydela v-kydela self-assigned this Oct 28, 2020
@v-kydela
Copy link
Contributor

Thank you for the report, @Andrew47

It looks like the instructions for using a Slack adapter are indeed incorrect and will need to be updated here, here, and here. In addition to the problems you stated, it looks like the instructions also say to subscribe to the event im_created which doesn't exist.

The docs page currently has four open issues, so hopefully the instructions will be redone to account for the way Slack currently works. In the meantime, you can get past your issues like this:

  • Skip to "Update your Slack app" step 4 to see what bot token scopes to add in order to install your app and get a bot token
  • I think it's just one URL, but in two places
  • It's referring to the "/api/slack" URL

I will unassign myself so the appropriate people can have a look at this.

@v-kydela v-kydela added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label Oct 28, 2020
@v-kydela v-kydela removed their assignment Oct 28, 2020
@jwiley84
Copy link
Contributor

Hi @Andrew47 The Slack documentation has recently been updated. Can you attempt to reconnect slack using the updated instructions and let me know how it goes?

@apburnie
Copy link
Author

Hi @jwiley84

Thank you for coming back on the above raised issues with the documentation - it is very much appreciated.

I think the problems described above are with the recently updated Slack documentation. I have had another look at the documentation and am still finding that the above issues exist. The README file was updated 9 months ago, whilst the above issues were detected 16 days ago. For convenience, the problems described above are with the documentation at https://github.com/microsoft/BotBuilder-Samples/tree/main/samples/python/60.slack-adapter.

Once again, thanks for your help on this issue. I am looking forward to its resolution.

@jwiley84
Copy link
Contributor

jwiley84 commented Nov 13, 2020

Oh! I apologize. I just saw that I didn't link the documentation I was talking about: https://docs.microsoft.com/en-us/azure/bot-service/bot-service-channel-connect-slack?view=azure-bot-service-4.0&tabs=abs

I will double check the readme on this sample and get any incorrect portion fixed. Thank you for bringing this to our attention.

@tonyanziano
Copy link

@jwiley84 any updates on fixing the documentation?

@EricDahlvang
Copy link
Member

The readme updates have been merged. Thanks @jwiley84

@v-kydela
Copy link
Contributor

Was there a decision made to only update the instructions in one place instead of three? And was it determined that im_created is a Slack event after all?

@EricDahlvang
Copy link
Member

@v-kydela Should more places be updated? I'm not sure about im_created, is it a Slack event after all?

@v-kydela
Copy link
Contributor

@EricDahlvang - Are you able to see the comment I made on October 28 containing the research I did before unassigning myself?

@EricDahlvang
Copy link
Member

Yes, i'm able to see the comment.

@v-kydela
Copy link
Contributor

Reopening as not resolved. Please refer to this comment to see what needs to be fixed.

@v-kydela v-kydela reopened this Jan 21, 2021
@EricDahlvang
Copy link
Member

@v-kydela the referenced docs page no longer has four open issues. I do not have the context to know if that means the above has been fully resolved. Please describe which part of your comment above still needs to be addressed, and what you recommend?

@v-kydela
Copy link
Contributor

@EricDahlvang - It all still needs to be addressed except for the part JJ fixed. It doesn't look like the open issues I mentioned were relevant here. I recommend transferring this to the docs team so they can come up with new instructions based on how Slack currently works.

JJ fixed the three specific things the customer mentioned in the one specific document the customer was looking at, but she missed the problem with obsolete Slack events. So to resolve this issue, we could fix the im_created problem in the Python readme and fix all four problems in the C# readme and the bot docs. I'm reluctant to leave it at that because there are more points of confusion in the Slack adapter instructions and I think it deserves a thorough read-over. I opened an issue in the .NET repo because the Slack adapter itself is confusing: microsoft/botbuilder-dotnet#5115

@jwiley84 jwiley84 assigned v-kydela and unassigned EricDahlvang and jwiley84 Jan 22, 2021
@srinaath
Copy link

srinaath commented Feb 4, 2021

Closing for inactivity.

@srinaath srinaath closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants