Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix Slack adapter configuration #5115

Closed
v-kydela opened this issue Jan 21, 2021 · 1 comment
Closed

Please fix Slack adapter configuration #5115

v-kydela opened this issue Jan 21, 2021 · 1 comment
Assignees
Labels
Area: Custom adapters The issue is related to custom adapters (Twilio, Facebook, etc.) bug Indicates an unexpected problem or an unintended behavior. feature-request A request for new functionality or an enhancement to an existing one.

Comments

@v-kydela
Copy link
Contributor

Version

main branch

Describe the bug

The Slack adapter uses the following configuration settings:

{
  "SlackVerificationToken": "",
  "SlackBotToken": "",
  "SlackClientSigningSecret": ""
}

There are a few problems with this:

  1. The verification token is deprecated. According to Slack: "This deprecated Verification Token can still be used to verify that requests come from Slack, but we strongly recommend using the above, more secure, signing secret instead."
  2. It's unclear whether "SlackClientSigningSecret" refers to the client secret or to the signing secret, so the name should be changed.

Expected behavior

The Slack adapter should not use the verification token and should not have ambiguous configuration settings.

@v-kydela v-kydela added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jan 21, 2021
@mrivera-ms mrivera-ms self-assigned this Jan 27, 2021
@mrivera-ms mrivera-ms added Area: Custom adapters The issue is related to custom adapters (Twilio, Facebook, etc.) and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Jan 27, 2021
@tonyanziano tonyanziano added the feature-request A request for new functionality or an enhancement to an existing one. label Jul 22, 2021
@haacked
Copy link
Contributor

haacked commented Dec 13, 2021

Please reopen this issue as it hasn't been addressed. The docs here is outdated and looking at the SlackAdapter code, it looks like it still wants us to pass a deprecated SlackVerificationToken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Custom adapters The issue is related to custom adapters (Twilio, Facebook, etc.) bug Indicates an unexpected problem or an unintended behavior. feature-request A request for new functionality or an enhancement to an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants