corebot updates to support gov cloud #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AdapterWithErrorHandler to use IConfiguration Update csproj to use 4.4.5 bot fx Remove ICredentialProvider from startup.cs
gabog
approved these changes
Jun 27, 2019
| @@ -20,9 +20,6 @@ public void ConfigureServices(IServiceCollection services) | |||
| { | |||
| services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Version_2_1); | |||
|
|
|||
| // Create the credential provider to be used with the Bot Framework Adapter. | |||
| services.AddSingleton<ICredentialProvider, ConfigurationCredentialProvider>(); | |||
There was a problem hiding this comment.
Based on this change, I think the ConfigurationCredentialProvider class in the CoreBot project can be removed, right?
There was a problem hiding this comment.
I can pull this, though there is a ticket that is being worked on to pull this from all the samples that use it.
sgellock
pushed a commit
that referenced
this pull request
Jul 19, 2019
* improved handling of LUIS response * Remove CreateReply (use MessageFactory) * Refactored code to make it easier to test. Updated messages and prompts so they work with speech. * Renamed file to match class name * Updated comments. * Updated MessageFactory.Text creation to use new sequence and made it consistent across the board. * Gabog/corebot updates with unit tests (#1590) * Added UnitTests for CoreBot * Added readme file * Testing images in readme * WIP updated Readme. * Updated readme * Added Analyzing Test Output section to redame * Added link to xunit docs * Added Theory tests with InlineData section * Fixed some typos * allow latest C# features * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * Fixes 1558 - corebot should work in gov cloud (#1602) Update AdapterWithErrorHandler to use IConfiguration Update csproj to use 4.4.5 bot fx Remove ICredentialProvider from startup.cs * Update CoreBot .NET Template update AdapterWithErrorHandler to use new constructor update cs proj to 4.4.5 version of bot fx remove ICredentialProvider from statup.cs remove ConfigurationCredentialProvider.cs * Remove ConfigurationCredentialProvider and DialogExtensions from CoreBot * Removed unused using directive * Updated CoreBot.Tests to use the latest Testing package and fixed issues caused by breaking changes. * Gabog/corebot updates/js updates with tests (#1628) * Initial readme cloned from dotnet * Readme updates * Readme updates. Moved images to a new folder. * Updated corebot JS to the new version with unit tests. Updated comments and some names in the C# version for parity with JS. * Removed images (they've been moved to docs.microsoft.com) Shortened the readme and added link to docs.microsoft.com * Fixed broken link. * Updated JS readme. Fixed some typos. * Fixed links * Update README.md Added channel ID * Update README.md Removed await from getNextReply * updated middleware array to be of type IMiddleware * re-remove logger, various cleanup * fix remaining eslint errors in core-bot * remove at-mention code, cleanup config for LUIS * remove extra dep, use getter in flightBookingRecognizer * cleanup mainDialog and its tests in JS core-bot * update dependencies, fix npm audit report * Updated links to doc (temporarily until we get the aka.ms ones) * Updated links to packages and docs. * Updated link test * Cleanup corebot and corebot-test * Updated project to reference Microsoft.AspNetCore.App instead of individual apsnet core packages to avoid conflicts when changing TargetFramework. * Update CoreBot .NET Template - restructure folder to enable CoreBot and CoreBot.Tests - update CoreBot to use latest structure - update to use 4.5 of Bot Framework - update README.md to document how to use —include-tests command line option and the fact that generating CoreBot.Tests is a new capability of the template - minor bug fixes - bump version numbers to 4.5.0 * Update link to test docs replace placeholder link to use correct aka.ms link * .NET Template for CoreBot updates update template code to match final version * Updated LUIS setup wording * .NET CoreBot Template default.html cleanup - removed old commented out markup * Corebot ts updates (#1648) * V3 state bot, and v4 state bot that uses Bot.Builder.Azure.V3ToV4 for UserState (#1573) * add v3 state bot, and v4 state bot that uses Bot.Builder.Azure.V3ToV4 to connect to v3 stored UserState * add/update migration readmes. Add AzureSql-CreateTable.sql remove secret from V3StateBot default.htm * [Expression_Document]Add doc for built-in functions (#1592) * Update the usage of TemplateEngine Update the usage of TemplateEngine. Currently, template engine will use new TemplateEngine().AddFiles() to load lg files * update usage doc of some date time functions * add some description for expression functions * Add some function description and examples * Add description & examples for built-in functions * Add examples and descriptions * add some conversion functions * fix some format and add some uri conversion func * Add missiong docs for built-in functions * delete fromFile in LG readme doc * Add parameters.json for ARM templates (#1627) * add initial ARM template parameters.json * cleanup ARM template parameters.json * add parameters.json files to all samples * add ARM parameter.json files to generators * update ts corebot sample, port tests * fix tslint errors, add tslint rules * apply init PR feedback to TS core-bot * apply @gabog's feedback to TS core-bot * remove redundant state save from TS core-bot * Updated MainDialog on all 3 languages to use the initialdialogID in the replace call and avoid creating infinite nested parents. * Updated projects to point to 4.5.1 Updated tests to pass. * Updated generators tests to pass with 4.5.1 * corebot yeaoman updates - corebot updates - prompting for test project, but to be implemented * pickup C# Core Bot feedback, update dependencies in dotnetcore * bug fixes, update to latest lint rules - use latest lint rules in prep for moving off of tslint - fix lint rule violations - fix broken aka.ms links with new working aka.ms link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1519
Update AdapterWithErrorHandler to use IConfiguration
Update csproj to use 4.4.5 bot fx
Remove ICredentialProvider from startup.cs